Bug - Fixed Kmail says acrimonies go to inventory, not Hagnks

[lotsofphil]

When PvP rewards are kmailed, they all go to Hagnks. For example:
You acquire 135 angst burgers (stored in Hagnk's Ancestral Mini-Storage)

But with the acrimonies, Mafia somehow suppresses the Hagnk's message:
You acquire 145 5-hour acrimonies [drink]

Bullet points:
* It is Mafia doing this. The kmails look normal in vanilla.
* The acrimonies did in fact go to Hagnks.
* There is no caching issue I can think of. I haven't won a PvP reward since season 1.
* Could it be an unrecognized plural?
* Could it be something with the [drink] link?

 

[Darzil]

I don't think mafia processes anything from Kmails. A refresh of inventory should pick up where it now is.

 

[lostcalpolydude]

I don't think mafia processes anything from Kmails. A refresh of inventory should pick up where it now is.

Mafia knows where the items are at, it's a text display issue. Apparently the [drink] link replaces the "(stored in Hagnk's Ancestral Mini-Storage)" message. I'm surprised it doesn't happen for angst burgers with an [eat] link. Maybe because the plural there is inferred (just an added s, so it isn't specified in items.txt) while acrimonies is listed specifically.

 

[lostcalpolydude]

A bit more checking confirms that mafia doesn't provide use/etc links for any plural name where the plural isn't specified, which probably isn't too hard to fix in

ItemDatabase.getCanonicalName( final String itemName, final int count, final boolean substringMatch )

The other issue is that use links override relevant KoL text.

 

[Veracity]

I can confirm this. To my surprise, I actually ended up on a leaderboard this last season...

Original text:

<table class="item" style="float: none" rel="id=5731&s=0&q=0&d=0&g=0&t=1&n=70&m=0&p=0&u=b"><tr><td><img src="http://images.kingdomofloathing.com/itemimages/potion13.gif" alt="5-hour acrimony" title="5-hour acrimony" class=hand onClick='descitem(922162926)'></td><td valign=center class=effect>You acquire <b>70 5-hour acrimonies</b> (stored in Hagnk's Ancestral Mini-Storage)</td></tr></table>

Munged text:

<table class="item" style="float: none" rel="id=5731&s=0&q=0&d=0&g=0&t=1&n=70&m=0&p=0&u=b"><tr><td><img src="/images/itemimages/potion13.gif" alt="5-hour acrimony" title="5-hour acrimony" class=hand onClick='descitem(922162926)'></td><td valign=center class=effect>You acquire <b>70 5-hour acrimonies</b> <font size=1>[<a href="javascript:singleUse('inv_booze.php','which=1&whichitem=5731&pwd=0408c2e5d73149d9cca0fd7e235d46a0&ajax=1');void(0);">drink</a>]</font></td></tr></table>

Shouldn't be hard to figure out before KoL purges it from my mailbox...

 

[Veracity]

Revision 14926