Bug - Fixed Infinite Mall Buying

[Tokoeka]

Weird bug with buying from mall when in-run (so items going to storage). First observed by Autoscend users when autoscend tried to buy items for the commerce ghost on 2/2/2022

using "buy from mall [item]" causes mafia to go into a loop buying 1 of the item from each stall that is selling it, even if one of the stores already bought from still has items remaining at a cheaper price.

Images show the failure state, and a couple of my tests

 

[HippoKing]

Update: a little testing shows that this is apparently limited to items that are free pulls, bought while in-run.

 

[Veracity]

Ha! I made a change that would move a free pull item to the free pull list, not storage - but apparently there is somewhere that checks if you actually got the item by looking at storage. I'll look into it.

 

[HippoKing]

Thanks for looking at it.

Also, I tested with a Time's Arrow, which is nominally a free pull but was not actually pullable because it's out of standard. Not sure if that will affect what lists you want things on for what you're doing.

 

[Veracity]

I have a PR in which fixes this issue.

 

[Ashleyc]

Thank you for looking into this and fixing so promptly!

 

[ALLENGENORAGA]

thank you Vera!