Bug - Fixed Infinite loop when attempting to rest with no adventures

[Fred Nefler]

When using the command "camp rest <number of times>", mafia currently does not recognize the message that tells you you are out of adventures. As such it will attempt to rest indefinitely with no success until you force it to stop. The game message when out of adventures is:

You don't have any time left for today.

EDIT: Okay, not quite infinite loop. Each failed attempt will increment the request counter by 1. So if you tell it to rest 200 times with 0 adventures left it'll attempt to rest 200 times in a row (without success). Still, that's at least 199 more than it should.

 

[lostcalpolydude]

Mafia shouldn't need to recognize that message, it should know before trying that resting won't do anything if you don't have adventures remaining (and if it will take a turn).

 

[Fred Nefler]

I'm not entirely sure it can, as I was noticing that the charpane in-browser never updated after a rest.

 

[Veracity]

Does this still happen, since we no longer go to the charpane after internally generated requests?

 

[Veracity]

> camp rest 5

Campground request 1 of 5 in progress...

You don't need to rest.

As lost pointed out, it did not even submit a request.

I cannot reproduce this.

 

[Yendor]

If you're at full HP and MP, it'll tell you you don't need to rest. If you're not, and have no adventures, it will go through the loop making multiple requests with no result.

> camp rest 5

Campground request 1 of 5 in progress...

[40246] Rest in your dwelling

Campground request 2 of 5 in progress...

[40246] Rest in your dwelling

Campground request 3 of 5 in progress...

[40246] Rest in your dwelling

Campground request 4 of 5 in progress...

[40246] Rest in your dwelling

Campground request 5 of 5 in progress...

[40246] Rest in your dwelling

Requests complete.

 

[lostcalpolydude]

Fixed in 13100.