Help with Modifier Maximiser

Elberon

New member
It seems like my Mod maximiser is stubbornly refusing to consider the mall for some reason?
Preferences:
1634785800171.png
settings
1634785856401.png
I've tried most combinations of the radio buttons in the settings, and have no idea what I'm doing wrong. Could someone be kind enough to explain what exactly I'm messing up?
 

MCroft

Developer
Staff member
It seems like my Mod maximiser is stubbornly refusing to consider the mall for some reason?
I've tried most combinations of the radio buttons in the settings, and have no idea what I'm doing wrong. Could someone be kind enough to explain what exactly I'm messing up?
Have you tried a non-zero max purchase price?
 

Elberon

New member
Have you tried a non-zero max purchase price?
I might have already, but I definitely have now. A sufficiently large number to buy a dead guy's watch, and all three of 'don't check' 'buyable only' and 'all consumables'. No change.
 

MCroft

Developer
Staff member
Hmm. How about maximizing adv, 2 dump

Also, is there anything unexpected in the session log, or the DEBUG log? Debug log might be unexpected just by existing...
 

MCroft

Developer
Staff member
DEBUG log would be one level back from session logs, and only exists if something goes wrong (or you ask for one).

2 dump keyword puts data in the gCLI.
 

Elberon

New member
Ah,
Maximizer: adv, 2 dump
Maximizing...
Outfits [Time Trappings]
SLOT 0
[Knob Goblin harem veil (10), ravioli hat (10), seal-skull helmet (10), Hollandaise helmet (10), disco mask (10), helmet turtle (10), bugbear beanie (10), pail (10), eyepatch (10), foolscap fool's cap (10), topeé (10), filthy knitted dread sack (10), lihc face (10), brown paper bag mask (10), draggin' ball hat (10), wolf mask (10), eXtreme scarf (10), f3d0r4 (10), Mohawk wig (10), Crown of the Goblin King (10), Disco 'Fro Pick (10), fuzzy montera (10), Hairpiece On Fire (14)]
[Hairpiece On Fire]
SLOT 1
[grave robbing shovel (14), wooden stakes (14), spooky stick (14), rusty grave robbing shovel (14), rubber axe (14), infernal fife (14), big bass drum (14), bone flute (14), plastic guitar (14), ridiculously huge sword (14), Shagadelic Disco Banjo (14), drywall axe (14)]
[drywall axe]
SLOT 2
[(none) (14)]
[(none)]
SLOT 3
[security flashlight (14), stuffed frozen gravy fairy (14), UV-resistant compass (14), (none) (14), box (14), hot plate (14), Victor, the Insult Comic Hellhound Puppet (14), flaming talons (14), 2-ball (14), 5-ball (14), Whatsian Ionic Pliers (14), disturbing fanfic (14), little black book (14)]
[little black book]
SLOT 4
[Misty Cape (14)]
[Misty Cape]
SLOT 5
[(none) (14)]
[(none)]
SLOT 6
[old sweatpants (14), Knob Goblin harem pants (14), bugbear bungguard (14), Knob Goblin pants (14), antique greaves (14), giant discarded torn-up glove (14), filthy corduroys (14), bloody clown pants (14), topiary tights (14), three-legged pants (14), snowboarder pants (14), swashbuckling pants (14), dress pants (14)]
[dress pants]
SLOT 7
[acid-squirting flower (14), continuum transfunctioner (14), giant pinky ring (14), Lord Spookyraven's spectacles (14), rubber WWBD? bracelet (14), diamond necklace (14), freshwater pearl necklace (14), Pine-Fresh air freshener (14), glowing red eye (14), ring of half-assed regeneration (14), topiary necktie (14), dirty hobo gloves (14), Claybender glasses (14), stuffed shoulder parrot (14), observational glasses (14), Duskwalker fangs (14), eXtreme mittens (14), duonoculars (14), clown shoes (14), big red clown nose (14), Baron von Ratsworth's monocle (14), walrus-tusk earring (14), imp unity ring (14), loafers (14), lucky rabbit's foot (14), shiny ring (14), ghost of a necklace (14), badass belt (14), sweat socks (14), gold wedding ring (15)]
[gold wedding ring, sweat socks, badass belt]
SLOT 8
[antique spear (14), (none) (14), seal-clubbing club (14), turtle totem (14), pasta spoon (14), saucepan (14), asparagus knife (14), Knob Goblin scimitar (14), Knob Goblin tongs (14), Gnollish plunger (14), skeleton bone (14), little paper umbrella (14), broken sword (14), cardboard katana (14), diamond-studded cane (14), spiked femur (14), kneecapping stick (14), hilarious comedy prop (14), soap knife (14), elegant nightstick (14)]
[elegant nightstick]
SLOT 9
[(none) (14), disco ball (14), sewer snake (14)]
[sewer snake]
SLOT 10
[little bitty bathysphere (14), (none) (14)]
[(none)]
SLOT 11
[(none) (14)]
[(none)]
SLOT 12
[(none) (14)]
[(none)]
SLOT 13
[]
[]
SLOT 14
[antique spear (14), seal-clubbing club (14), turtle totem (14), pasta spoon (14), saucepan (14), disco ball (14), asparagus knife (14), Knob Goblin scimitar (14), Knob Goblin tongs (14), Gnollish plunger (14), skeleton bone (14), little paper umbrella (14), sewer snake (14), broken sword (14), cardboard katana (14), diamond-studded cane (14), spiked femur (14), kneecapping stick (14), hilarious comedy prop (14), soap knife (14), elegant nightstick (14)]
[elegant nightstick]
SLOT 15
[(none) (14)]
[(none)]
SLOT 16
[(none) (14)]
[(none)]
SLOT 17
[(none) (14)]
[(none)]
SLOT 18
[(none) (14)]
[(none)]
SLOT 19
[(none) (14)]
[(none)]
SLOT 20
[(none) (14)]
[(none)]
SLOT 21
[(none) (14)]
[(none)]
SLOT 22
[(none) (14)]
[(none)]
SLOT 23
[(none) (14)]
[(none)]
Just doesn't seem to be seeing the mall for some reason. Is there something I need to do to turn that on? My account has access to the mall, of course.
 

MCroft

Developer
Staff member
have you tried to use historical prices and deleted your historical prices (to force new price checks?)

You should have a file in your data directory called mallprices.txt
Mine has 7508 lines of data that matches item number, other item number, and 5th lowest mall price.
Michaels-MBP:data mcroft$ wc -l mallprices.txt 7508 mallprices.txt Michaels-MBP:data mcroft$ tail mallprices.txt 10778 1634769672 156 10784 1634769672 3000 10785 1634769673 301 10786 1634769674 900 10787 1634784169 100 10788 1634786043 555 10796 1634702834 45000000 10798 1634770249 2920000 10801 1634702834 43000000 10802 1634698584 17996
 

Elberon

New member
have you tried to use historical prices and deleted your historical prices (to force new price checks?)
Would my data directory have files named [Playername]_queue.ser, [Playername]_turns.ser, itemflags, and svnrepo?
If so, it does not seem to have a historical prices file.

Is the Maximizer interacting with autoBuyPriceLimit ?
I'm unsure what that is, how would I check that?
 

fronobulax

Developer
Staff member
mallprices.txt has the historical prices but it will not be in data unless you have enabled the preference to share prices. Otherwise it is not updated and is whatever got bundled in the KoLmafia jar.

autoBuyPriceLimit is a preference which you can set via the command line. In many places mafia will refuse to do automated buying if the mall price exceeds the limit. We question was aimed at people who know the code better than I do.

In a hurry. I'll revisit later if I need to be less terse.
 

Elberon

New member
mallprices.txt has the historical prices but it will not be in data unless you have enabled the preference to share prices. Otherwise it is not updated and is whatever got bundled in the KoLmafia jar.
How do I enable the preference to share prices? That sounds like it could be my problem.
 

fronobulax

Developer
Staff member
How do I enable the preference to share prices? That sounds like it could be my problem.

Go to the preferences tab or window. Select General (on the left). Scroll down on the right and check Share recent Mall price data with other users. Restart mafia.

While you are there you might also look at General->Item Acquisition since the Buy Items from Mall whenever needed might be affecting the maximizer.

If Share is already checked and there is no mallprices.txt in data then something is not working as expected and we should probably explore that even though it is probably not the total cause of of what you are seeing.
 

Elberon

New member
Go to the preferences tab or window. Select General (on the left). Scroll down on the right and check Share recent Mall price data with other users. Restart mafia.

While you are there you might also look at General->Item Acquisition since the Buy Items from Mall whenever needed might be affecting the maximizer.

If Share is already checked and there is no mallprices.txt in data then something is not working as expected and we should probably explore that even though it is probably not the total cause of of what you are seeing.
I now have a mallprices file, but the Maximizer's behavior is unchanged.

Aha! Turning on 'Buy Items from Mall whenever needed' fixed my problem. Thanks so much for your help, everyone!
 
Top