philmasterplus
Active member
KoLmafia augments the right-click menu with a [wiki] link to the item's KoL wiki page. However, there's a small bug in the JavaScript code that handles item names with multiple spaces. It only replaces the first space character.
For example, the [wiki] link for Knob Goblin Pants leads to:
...instead of the intended URL:
This may have worked in the past, but fails now due to the wiki's HTTP → HTTPS redirection issue (which also caused a similar issue in OCD Inventory Control.)
I'm submitting a patch that fixes this in two ways. Use
Edit: Updated patch to handle issue discussed in reply #2
Edit 2021-01-09: Updated patch to resolve merge conflict after r20600
For example, the [wiki] link for Knob Goblin Pants leads to:
Code:
http://kol.coldfront.net/thekolwiki/index.php/Special:Search?go=Go&search=Knob+Goblin%20pants
Code:
http://kol.coldfront.net/thekolwiki/index.php/Special:Search?go=Go&search=Knob+Goblin+pants
This may have worked in the past, but fails now due to the wiki's HTTP → HTTPS redirection issue (which also caused a similar issue in OCD Inventory Control.)
I'm submitting a patch that fixes this in two ways. Use
encodeURIComponent()
all the way instead of regexes, and (2) use a https://
URL.Edit: Updated patch to handle issue discussed in reply #2
Edit 2021-01-09: Updated patch to resolve merge conflict after r20600
Attachments
Last edited: