Currently when you run maximize via some method that doesn't return a boolean, the script cannot tell if the maximize failed or not.
I'd personally prefer not to call two maximizes, when I should only need to call one. Especially because you can, with the below method, limit the scope the maximizer will check. Useful for performance.
This returns an array of modifiers, it does not tell us, as far as I can tell, if the maximizer actually failed.
So I was wondering about adding
I'm not really sure what would be a good way to expose this.
So, rather than open a PR, thought it'd be better to post here and see if someone has an idea.
I'd personally prefer not to call two maximizes, when I should only need to call one. Especially because you can, with the below method, limit the scope the maximizer will check. Useful for performance.
maximize("maximize string", 2500, 0, -1, "equip")This returns an array of modifiers, it does not tell us, as far as I can tell, if the maximizer actually failed.
So I was wondering about adding
maximizer_failed(), but then maybe we'd want instead the inverse maximizer_success()I'm not really sure what would be a good way to expose this.
boolean_modifier("_spec:Success") doesn't seem like a good option either, as it's meant for a Modifier, not a placeholder.So, rather than open a PR, thought it'd be better to post here and see if someone has an idea.