Laserrobotics
Member
So this one's hard to word properly, so I'll start out with the specific example. I have an outfit called Regular that has the Sledgehammer of the Valkyr in my main hand and an Icy Shield in my offhand. My Underwater outfit has a Mer-Kin Hookspear in my main hand and the Sledgehammer of the Valkyr in the off hand, for reasons that probably made sense at the time. If I have Regular equipped, and use Mafia to put on Underwater, it does so without complaint. Here's the problem: the KoL inventory will show me having the Sledgehammer of the Valkyr in the main hand and the Mer-Kin Hookspear in the off hand, while Mafia is under the impression that I am holding the Mer-Kin Hookspear in my main hand and nothing in the off hand. Furthermore, trying to use Mafia to equip the Sledgehammer of the Valkyr in the off hand results in it telling me I don't have that item (because it is in fact equipped). Refreshing my character status in Mafia corrects the inconsistency.
I'm guessing this is in part due to how KoL interprets the outfit request: Using KoL itself to make the swap has the same result in that I end up with the Hookspear in the offhand, while equipping Underwater with empty hands puts the Hookspear in the main hand.
Steps to reproduce:
I'll add some more here like what I'd like to see and reasons it's important but have run out of time, I'll be back in a few hours. Just want to get this out first so you can see it.
EDIT: Since this is primarily a bug with KoL, I understand if you want to follow your policy of not correcting for those. However, here is what I would like to see:
When equipping an outfit, have Mafia check against its cached version of what the player is wearing. If the desired main or off hand is already equipped in the opposite slot, before sending the outfit request simply unequip both slots. I believe this would suffice to solve the issue because the only other slots that items can go in any of are the accessories, where slot number doesn't matter. If I understand correctly, there are a few instances where it is important that a weapon be in the main hand over the off hand.
So my idea for the fix would work like this:
I hope that makes it clear? Let me know if it's not.
I'm guessing this is in part due to how KoL interprets the outfit request: Using KoL itself to make the swap has the same result in that I end up with the Hookspear in the offhand, while equipping Underwater with empty hands puts the Hookspear in the main hand.
Steps to reproduce:
- Have only 1 of 1-handed weapon A, have 1-handed weapon B, have off-hand item x, have Double Fisted Skull Smashing.
- Create outfit with weapon A in main hand and item x in off hand.
- Create outfit with weapon B in main hand and weapon A in off hand.
- Unequip everything.
- Equip outfit A, note resulting equipped gear in Mafia and KoL corroborate.
- Equip outfit B, note that Mafia reports (main/off) B/(nothing) while KoL reports A/B, despite outfit being B/A.
I'll add some more here like what I'd like to see and reasons it's important but have run out of time, I'll be back in a few hours. Just want to get this out first so you can see it.
EDIT: Since this is primarily a bug with KoL, I understand if you want to follow your policy of not correcting for those. However, here is what I would like to see:
When equipping an outfit, have Mafia check against its cached version of what the player is wearing. If the desired main or off hand is already equipped in the opposite slot, before sending the outfit request simply unequip both slots. I believe this would suffice to solve the issue because the only other slots that items can go in any of are the accessories, where slot number doesn't matter. If I understand correctly, there are a few instances where it is important that a weapon be in the main hand over the off hand.
So my idea for the fix would work like this:
- User/script requests outfit change
- Mafia compares Main Hand slot and Off Hand slot in requested outfit to what it has cached as currently equipped
- If the requested Main Hand is currently in the cached Off Hand, or the requested Off Hand is currently in the cached Main Hand, send KoL a request to unequip Main Hand and Off Hand
- Send KoL outfit change request
I hope that makes it clear? Let me know if it's not.
Last edited: