I haven't tested it yet, since I am out of turns, but good.
New Content - Implemented Disco Bandit Revamp
- Thread starter Bale
- Start date
Well... the first character that forces UneffectRequest to get loaded will get those skills added to the static array - or not - depending on whether they have Adventurer of Leisure. If that character logs out and you log in with a different one without restarting KoLmafia, that array is never touched again.
I suggest that you make a static method UneffectRequest.reset() which is essentially the contents of that static block and which is called by KoLMafia.refreshSession() after it has read the charsheet and thus knows what your skills are. Presumably also in KoLmafia.resetAfterAvatar(), since that also reads the charsheet to see what your new skills are.
xKiv
Active member
When I tested disco face stab as a seal clubber:
12 is not 9*2 
[of course, I forgot to test DFS without SM as a not-DB ... maybe that's been nerfed to 6?]
BTW, now that I look at that,I notice that the "xKiv casts $skill" seems to be reported one round too early ... shall I create a bug report?
Actually ...
... so round number seems to increment too early and often?
Code:
Round 2: xKiv casts STEALTH MISTLETOE!
Round 3: xKiv casts DISCO FACE STAB!
Round 4: sleaze bugbear takes 65 damage.
Round 4: sleaze bugbear drops 12 attack power.
Round 4: sleaze bugbear drops 12 defense.
Round 4: sleaze bugbear takes 15 damage.
Round 4: One of the mayflies flies into your opponent's throat, causing him to gag and reel.
Round 4: xKiv casts OFFENSIVE JOKE!
Round 5: sleaze bugbear takes 1 damage.
Round 5: sleaze bugbear drops 20 attack power.
Round 5: sleaze bugbear drops 20 defense.BTW, now that I look at that,I notice that the "xKiv casts $skill" seems to be reported one round too early ... shall I create a bug report?
Actually ...
Code:
Round 0: xKiv wins initiative!
Round 0: xKiv casts SUMMON MAYFLY SWARM! (auto-attack)
Round 2: You open the little container full of mayfly bait and swing it around. A massive swarm of mayflies buzzes into the area.Regarding the "xkiv casts x skill":
Assume it is Round 0 if you get the jump, round 1 if you don't.
In either case, when you use a skill, cast a spell, or attack, it is happening in round 0 or 1.
We submit the request to fight.php.
The response comes in and we increment the round.
We report all the results as happening in the new round.
Now, KoL itself tells us the round that it thinks it is during each response to a fight.php request.
There is an existing bug report, somewhere, that says we should simply log KoL's round.
That's probably right, but it's not something I, personally, have any interest in looking at, right now.
Assume it is Round 0 if you get the jump, round 1 if you don't.
In either case, when you use a skill, cast a spell, or attack, it is happening in round 0 or 1.
We submit the request to fight.php.
The response comes in and we increment the round.
We report all the results as happening in the new round.
Now, KoL itself tells us the round that it thinks it is during each response to a fight.php request.
There is an existing bug report, somewhere, that says we should simply log KoL's round.
That's probably right, but it's not something I, personally, have any interest in looking at, right now.
Bale
Minion
Update KoLmafia to the latest build. I can verify that r12939 did cocktailcrafting as part of today's breakfast for me.
That is probably unrelated, any changes from this update would affect only two days, not a few, and breakfast still cast cocktailcrafting for me even with no changes to the handling in Mafia.
That is the case for any free round action, KoL doesn't increment the counter but Mafia does. I haven't looked to see if the mafia round number is used for decision making within mafia, if so not incrementing for free round actions may cause processing issues.
Or you know, put the reset call at the end of charpane parsing - and whatever is called when you learn a new skill.
You get the idea.
I presumed you meant character sheet, and also added it to guild request for skill learning. Also sorted expected HP restore from Disco Nap for Recovery Manager, and updated it in the same places.
r12940.
Bale
Minion
That is an awesome idea! Having 1 summon a day instead of 5 will already break scripts, so we might as well go whole hog and change to an underline preference. We'll probably even get the chance to do the same with reagent and pasta summoning later.
You are in KOLHS. That is considered to be a "no drinking" path, since you can't actually drink the things you can summon. Therefore, "breakfast" doesn't spend the MP to get such things. You have several options:
- Preferences/Automation/In Ronin - uncheck "honor path restrictions"
- Cast the skill yourself on Use Skills or via the "cast" command
Fluxxdog
Active member
You know, I totally forgot about $skill[].daily_limit
Derp.r12943 - Implements this. I will really enjoy Entangling Noodles enabling again after using a Tangle of Rat Tails.
Almost certainly (ie Yes, but untested). As long as you are talking about CAB handling.