Bug - Fixed Decorating Crimbo Shrub is marked as successful when it shouldn't be

[Baden]

Attempting to decorate a Crimbo Shrub via visit_url without actually having obtained the decorations (by equipping the Crimb Shrub) results in mafia thinking it was successful despite it not being actually decorated.

You don't have that item.
Preference    _shrubDecorated changed from false to true
Preference shrubLights    changed from to Spooky
Preference shrubGarland changed from to blocking
Preference    shrubGifts changed from to meat

 

[gausie]

I will fix this but I must say that not checking you have an item before using it and then not checking you're in a choice before attempting to choose that choice is silly.

 

[gausie]

Do not process choices when we get a "whoops" response by gausie · Pull Request #936 · kolmafia/kolmafia

Do folks reckon I should add a KoLmafia.updateDisplay(MafiaState.ERROR, "Whoops! You're not actually in a choice adventure"); or something?

github.com