Bug Crimbo Training skills appear to not have correct numeric modifiers set up

[Tokoeka]

If you do a modtrace for relevant modifiers for each of the crimbo training skills, they show up in the mod trace results (as per image).

However, if you do a numeric_modifier check on them, they appear to not have the relevant modifier (as per second image)

I have checked this for all of the crimbo training skills (and their relevant stat), and it appears to be the case for all of them.

 

[Tokoeka]

From investigating modifiers.txt they do appear to have the correct info listed in there, so my best guess(es) are it might be incorrectly formatted in there, or it may be due to the colon in their names?

 

[Rinn]

The colon would make sense because that's used to split the modifier type and the value, and if that's also splitting the skill name string it would probably explain this.

 

[MCroft]

That's correct. It's in the data source correctly, but the ash function numeric_modifier relies on getModifierName, which has always stripped off anything before the ":" character in the name.

I'm putting up a PR.