So, I'm not sure exactly how to reproduce this in a platform-independent way, but I do sometimes see failures for this one test.
Typically of the form:
One thing I've noted is that `thing = usableList.getSize()` (all visible elements) is being compared against `usableList.size()` (all elements). @fronobulax what is the intent of this test? It's not clear to me what it should be (although from the naming it probably shouldn't be concerned with element visibility).
If I change .getSize() to .size() it passes, although it still doesn't assert what I'd expect it to (namely that the resulting list is in sorted order).
(I also have no idea how this list's elements are sometimes just not visible, although that would help with understanding how to reproduce the test failures.)
Typically of the form:
Java:
org.opentest4j.AssertionFailedError: expected: <10869> but was: <0>
at app//org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
at app//org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)
at app//org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:150)
at app//org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:145)
at app//org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:527)
at app//net.sourceforge.kolmafia.objectpool.ConcoctionTest.itShouldSortUsables(ConcoctionTest.java:30)
...
One thing I've noted is that `thing = usableList.getSize()` (all visible elements) is being compared against `usableList.size()` (all elements). @fronobulax what is the intent of this test? It's not clear to me what it should be (although from the naming it probably shouldn't be concerned with element visibility).
If I change .getSize() to .size() it passes, although it still doesn't assert what I'd expect it to (namely that the resulting list is in sorted order).
(I also have no idea how this list's elements are sometimes just not visible, although that would help with understanding how to reproduce the test failures.)