Bug - Fixed beGregariousFightsLeft is decremented when encountering other sources of the beGregariousMonster

Code:
use 1 envyfish egg
Preference envyfishMonster changed from Knob Goblin Embezzler to
Preference _envyfishEggUsed changed from false to true
Preference lastAdventure changed from Noob Cave to None

[718439] envyfish egg
Preference lastEncounter changed from crate to Knob Goblin Embezzler
Encounter: Knob Goblin Embezzler
Preference _lastCombatStarted changed from 20211222071140 to 20211222071311
Preference beGregariousFightsLeft changed from 3 to 2

Haven't tested timespinner or any other copies yet but I would suspect they're no different. Digitize, macrometeorite/replace & backup seem fine though.
 

Zdrvst

New member
Yeah, I noticed this today with 4-d camera and relativity:
Code:
use 1 shaking 4-d camera
Preference cameraMonster changed from Knob Goblin Embezzler to
Preference _cameraUsed changed from false to true
Preference lastAdventure changed from Noob Cave to None

[269] shaking 4-D camera
Encounter: Knob Goblin Embezzler
Preference _lastCombatStarted changed from 20211223025806 to 20211223025914
Preference beGregariousFightsLeft changed from 3 to 2

[270] null
Encounter: Knob Goblin Embezzler
Preference _relativityMonster changed from true to false
Preference _lastCombatStarted changed from 20211223025914 to 20211223025924
Preference beGregariousFightsLeft changed from 2 to 1

[271] null
Encounter: Knob Goblin Embezzler
Preference _relativityMonster changed from true to false
Preference _lastCombatStarted changed from 20211223025924 to 20211223025936
Preference beGregariousFightsLeft changed from 1 to 0
Set the property back to 3 and of course all 3 greg monsters were still there.
 
Last edited:

Manendra

New member
See below for the relevant section of the session log. But it looks like mafia saw the timespinner fight as a gregarious fight, and updated the pref accordingly. I was running r26090 at the time, I believe. Let me know if there's anything else you need that would be helpful!

Code:
use 1 Time-Spinner
Preference lastAdventure changed from The Dire Warren to None
Preference nextAdventure changed from Noob Cave to None

[147] Time-Spinner
Took choice 1195/1: (secret choice)
choice.php?whichchoice=1195&option=1&pwd
Preference lastEncounter changed from Knob Goblin Embezzler to Travel to a Recent Fight
Encounter: Travel to a Recent Fight
Took choice 1196/1: Spin and Fight!
choice.php?whichchoice=1196&monid=530&option=1

[147] A Recent Fight
Preference lastEncounter changed from Travel to a Recent Fight to Knob Goblin Embezzler
Encounter: Knob Goblin Embezzler
Preference semirareCounter changed from 146 to 147
Preference relayCounters changed from 114:Wormwood loc=151 loc=152 loc=153 place.php?whichplace=wormwood:tinybottle.gif:118:Wormwood loc=151 loc=152 loc=153 place.php?whichplace=wormwood:tinybottle.gif:122:Wormwood loc=151 loc=152 loc=153 place.php?whichplace=wormwood:tinybottle.gif:143:Latte Monster loc=*:snout.gif:151:Romantic Monster window begin loc=*:lparen.gif:161:Romantic Monster window end loc=* type=wander:rparen.gif:171:Digitize Monster loc=* type=wander:watch.gif:306:Semirare window begin loc=*:lparen.gif:346:Semirare window end loc=*:rparen.gif to 114:Wormwood loc=151 loc=152 loc=153 place.php?whichplace=wormwood:tinybottle.gif:118:Wormwood loc=151 loc=152 loc=153 place.php?whichplace=wormwood:tinybottle.gif:122:Wormwood loc=151 loc=152 loc=153 place.php?whichplace=wormwood:tinybottle.gif:143:Latte Monster loc=*:snout.gif:151:Romantic Monster window begin loc=*:lparen.gif:161:Romantic Monster window end loc=* type=wander:rparen.gif:171:Digitize Monster loc=* type=wander:watch.gif:346:Semirare window end loc=*:rparen.gif
Preference relayCounters changed from 114:Wormwood loc=151 loc=152 loc=153 place.php?whichplace=wormwood:tinybottle.gif:118:Wormwood loc=151 loc=152 loc=153 place.php?whichplace=wormwood:tinybottle.gif:122:Wormwood loc=151 loc=152 loc=153 place.php?whichplace=wormwood:tinybottle.gif:143:Latte Monster loc=*:snout.gif:151:Romantic Monster window begin loc=*:lparen.gif:161:Romantic Monster window end loc=* type=wander:rparen.gif:171:Digitize Monster loc=* type=wander:watch.gif:346:Semirare window end loc=*:rparen.gif to 114:Wormwood loc=151 loc=152 loc=153 place.php?whichplace=wormwood:tinybottle.gif:118:Wormwood loc=151 loc=152 loc=153 place.php?whichplace=wormwood:tinybottle.gif:122:Wormwood loc=151 loc=152 loc=153 place.php?whichplace=wormwood:tinybottle.gif:143:Latte Monster loc=*:snout.gif:151:Romantic Monster window begin loc=*:lparen.gif:161:Romantic Monster window end loc=* type=wander:rparen.gif:171:Digitize Monster loc=* type=wander:watch.gif
Preference relayCounters changed from 114:Wormwood loc=151 loc=152 loc=153 place.php?whichplace=wormwood:tinybottle.gif:118:Wormwood loc=151 loc=152 loc=153 place.php?whichplace=wormwood:tinybottle.gif:122:Wormwood loc=151 loc=152 loc=153 place.php?whichplace=wormwood:tinybottle.gif:143:Latte Monster loc=*:snout.gif:151:Romantic Monster window begin loc=*:lparen.gif:161:Romantic Monster window end loc=* type=wander:rparen.gif:171:Digitize Monster loc=* type=wander:watch.gif to 114:Wormwood loc=151 loc=152 loc=153 place.php?whichplace=wormwood:tinybottle.gif:118:Wormwood loc=151 loc=152 loc=153 place.php?whichplace=wormwood:tinybottle.gif:122:Wormwood loc=151 loc=152 loc=153 place.php?whichplace=wormwood:tinybottle.gif:143:Latte Monster loc=*:snout.gif:151:Romantic Monster window begin loc=*:lparen.gif:161:Romantic Monster window end loc=* type=wander:rparen.gif:171:Digitize Monster loc=* type=wander:watch.gif:307:Semirare window begin loc=*:lparen.gif
Preference relayCounters changed from 114:Wormwood loc=151 loc=152 loc=153 place.php?whichplace=wormwood:tinybottle.gif:118:Wormwood loc=151 loc=152 loc=153 place.php?whichplace=wormwood:tinybottle.gif:122:Wormwood loc=151 loc=152 loc=153 place.php?whichplace=wormwood:tinybottle.gif:143:Latte Monster loc=*:snout.gif:151:Romantic Monster window begin loc=*:lparen.gif:161:Romantic Monster window end loc=* type=wander:rparen.gif:171:Digitize Monster loc=* type=wander:watch.gif:307:Semirare window begin loc=*:lparen.gif to 114:Wormwood loc=151 loc=152 loc=153 place.php?whichplace=wormwood:tinybottle.gif:118:Wormwood loc=151 loc=152 loc=153 place.php?whichplace=wormwood:tinybottle.gif:122:Wormwood loc=151 loc=152 loc=153 place.php?whichplace=wormwood:tinybottle.gif:143:Latte Monster loc=*:snout.gif:151:Romantic Monster window begin loc=*:lparen.gif:161:Romantic Monster window end loc=* type=wander:rparen.gif:171:Digitize Monster loc=* type=wander:watch.gif:307:Semirare window begin loc=*:lparen.gif:347:Semirare window end loc=*:rparen.gif
Preference _timeSpinnerMinutesUsed changed from 6 to 9
Preference _lastCombatStarted changed from 20220103222022 to 20220103222031
Preference beGregariousFightsLeft changed from 1 to 0
Round 0: manendra wins initiative!
> if monsterid 530if snarfblat 186if hascombatitem pulled green taffyuse pulled green taffyendifendifif hasskill Wink atskill Wink atendifif hasskill Fire a badly romantic arrowskill Fire a badly romantic arrowendifif hascombatitem Spooky Putty sheetuse Spooky Putty sheetendifif hascombatitem Rain-Doh black boxuse Rain-Doh black boxendifif hascombatitem unfinished ice sculptureuse unfinished ice sculptureendifif hasskill Sing Alongskill Sing Alongendifif monsterid 1760if hasskill Transcendent Olfactionskill Transcendent Olfactionendifendifif monsterid 1760if hasskill Gallapagosian Mating Callskill Gallapagosian Mating Callendifendifif hasskill Pocket Crumbsskill Pocket Crumbsendifif hasskill 7273skill 7273endifwhile !pastround 3 && !hppercentbelow 25use seal toothendwhileif hascombatitem porquoise-handled sixgunuse porquoise-handled sixgunendifif hasskill Curse of Weaksauceskill Curse of Weaksauceendifwhile hasskill Saucegeyserskill Saucegeyserendwhilewhile hasskill Weapon of the Pastalordskill Weapon of the Pastalordendwhilewhile hasskill Cannelloni Cannonskill Cannelloni Cannonendwhilewhile hasskill Wave of Sauceskill Wave of Sauceendwhilewhile hasskill Saucestormskill Saucestormendwhilewhile hasskill Lunging Thrust-Smackskill 1005endwhileattackrepeatendifabort
Round 1: manendra executes a macro!
Round 1: manendra casts SING ALONG!
Round 2: manendra casts EXTRACT!
You acquire an item: Source essence
Round 3: You lose 1 hit point
Round 3: manendra uses the seal tooth!
Round 4: Knob Goblin Embezzler takes 1 damage.
Round 4: manendra uses the porquoise-handled sixgun!
Round 5: Knob Goblin Embezzler takes 27 damage.
Round 5: You gain 26 Mana Points
Round 5: manendra casts CURSE OF WEAKSAUCE!
Round 6: Knob Goblin Embezzler drops 5 attack power.
Round 6: Knob Goblin Embezzler drops 6 defense.
Round 6: manendra casts SAUCEGEYSER!
Round 7: Knob Goblin Embezzler takes 546 damage.
Round 7: A chill runs up your spine as Frozen or not, it's still fungus somehow manufactures some cold nuggets for you.
You acquire an item: cold nuggets
Round 7: Knob Goblin Embezzler drops 6 attack power.
Round 7: Knob Goblin Embezzler drops 5 defense.
Round 7: manendra wins the fight!
After Battle: You gain 50 Mana Points
After Battle: A love firefly flits flirtatiously around your head.
After Battle: You gain 5 Mysteriousness
After Battle: Frozen or not, it's still fungus surveys the scene from your back, and gains 1 Experience.
After Battle: Captain L3-37 emits an enthusiastic "Arrrr," grabs a shovel, and digs up some extra Meat for you. (+30% Meat Drops)
After Battle: L3-37 polishes a glass while winking at you.
You gain 25995 Meat
After Battle: Sly Flora gives you some meat under the table.
You gain 10 Meat.
After Battle: L3-37 does an elaborate bottle-juggling routine.
You acquire an item: meat stack
You acquire an item: meat stack
You acquire an item: meat stack
You acquire an item: meat stack
You acquire an item: Knob Goblin visor
After Battle: "Why Not Celebrate The Occasion With A Drink?" L3-37 says, offering you a cocktail mushroom.
You acquire an item: cocktail mushroom
After Battle: You gain 15 Beefiness
After Battle: You gain 28 Mysteriousness
After Battle: You gain 12 Sarcasm
Preference _boomBoxFights changed from 4 to 5
Preference lastAdventure changed from None to The Dire Warren
 
Spading suggests that the time-spinner does not append the gregarious message to the combat, which is weird.

Glancing at the mafia code, it seems like the issue is here; we first check for the greg text, and then check to see if there are fights left, and if neither of those are true, we return true if the monster we're fighting is the greg monster.

This seems like a bad idea! My (admittedly poor) understanding of this code would suggest that this would decrement your greg monster on just about any encounter you have with it. I feel like this should basically just check to see if it has the greg text, and return false otherwise.

Edit: Just put in my first mafia PR about this; I hope I've set everything up correctly, and am very open to any feedback anyone might have.
 
Last edited:

fronobulax

Developer
Staff member
Not sure (from personal experience and testing) that the PR is correct but it makes sense so...
 
It would make mafia more vulnerable to things like the DMT and other text-modifying effects messing with the tracking. But right now it looks like a lot of things that are much more common mess with the tracking.
 
Top