New Content - Rejected Barrel Full of Barrels

[Veracity]

(Does anybody use this?)

We have a fancy module - BarrelDecorator - to do special Stuff with this.
RequestEditorKit and GenericRequest and AdventureRequest have special code to handle it.
Supposedly, you can automate it.

In my current work of looking through which requests use turns, I saw references to barrel.php and needed to figure out what needed to be done.

Turns out, KoL has apparently moved that into a choice adventure.

You see a link to barrel.php in the Mountains, but if you take it,:

barrel.php
choice.php?forceoption=0
choice.php?whichchoice=1099&pwd&option=1&slot=00

... it redirects to choice #1099

That tells me everything I need to know about turn usage, but until/unless somebody modifies KoLmafia to use that choice rather than barrel.php, we have a lot of dead code.

 

[Magus_Prime]

FWIW: when I use the barrels I normally do so via the relay browser.

 

[Veracity]

Uh huh.

And we have fancy code to to decorate the page for you, showing predicted results and so on.
For barrel.php. Which means, it doesn't do that any more.

 

[Magus_Prime]

Huh. I could have sworn that I saw the decorations and predicted results the last time I visited, which was a week or so ago. The character with access to the barrels is overdrunk but I will check first thing tomorrow.

 

[Veracity]

Really? I literally just went there.

> get relayShowSpoilers

true

Nothing. No decorations.

> get barrelGoal

1

> get barrelLayout

?????????

> get lastBarrelSmashed

0

I smashed a barrel.

> get barrelGoal

1

> get barrelLayout

?????????

> get lastBarrelSmashed

0

Definitely not working.

 

[Magus_Prime]

My recollection, perhaps incorrect, was that none of the barrels on the first "screen" were decorated but after turning the crank they were decorated.

 

[Veracity]

I tried that. Certain barrels were decorated with a "!" - but that's from having a Barrel Shrine, not something that KoLmafia does.
There should have been tooltips, showing probabilities of various results.
No go. Instead there were the KoL tooltips "A barrel" and "A broken barrel".

 

[Magus_Prime]

That character does have a Barrel Shrine. There were no tooltips like you describe.

 

[Veracity]

You know something: after looking at the code, I now understand that the Barrel Decorator is based on the OLD Barrel Full of Barrels.
I.e., the 6 by 6 layout that was replace on August 25, 2015.

I think we should just retire this code. This PR does that.

The 6x6 Barrel Full of Barrels is dead. Long live the 3x3 replacement. by Veracity0 · Pull Request #1141 · kolmafia/kolmafia

As of August 25, 2015. I removed it as an "adventure". barrel.php just redirects to choice.php.

github.com

 

[txrangersxx]

I think this broke canadv.ash


Bad location value: "The Barrel Full of Barrels" (canadv.ash, line 405, char 19 to char 45)

 

[txrangersxx]

I commented the line out and it worked fine

 

[Veracity]

Before August 25, 2015, KoLmafia had good support for automating the Barrel Full of Barrels. You could set barrelGoal to specify what you wanted, and then automate - using the GUI or the CLI adventure command or the ASH adventure() function - for 12 turns.

On that day, KoL changed, and KoLmafia could no longer do that; the Barrel Full of Barrels ceased to be a functional “adventure”.

Which is to say, for more than seven years, no working script has used that as an adventure.

Not to say you can’t write a script to go there. Just that no working script will think it is an “adventure”.

Seven years later, you can’t even try; we removed it.

Long since time for scripts like CanAdv to remove code that refers to things that have been obsolete for seven years.

By the way, as of two weeks after that date, there was no need to “unlock” that location; it has been available since turn 1. All the more reason that you don’t need canAdv to help you decide if you can go there.

 

[taltamir]

I now recall that I did make a BR about it years ago

Bug - Barrel full of barrels automation doesn't work

Barrel full of barrels has automation options in mafia, letting you choose from 7 different options... and it doesn't work, trying to auto adventure in it always quits with the error Visit to Mountain: The Barrel Full of Barrels in progress... Unsupported choice adventure #1099 choice 1: A...

kolmafia.us

could probably go ahead and close that one too as a wontfix.

 

[Veracity]

I now recall that I did make a BR about it years ago

Bug - Barrel full of barrels automation doesn't work

Barrel full of barrels has automation options in mafia, letting you choose from 7 different options... and it doesn't work, trying to auto adventure in it always quits with the error Visit to Mountain: The Barrel Full of Barrels in progress... Unsupported choice adventure #1099 choice 1: A...

kolmafia.us

could probably go ahead and close that one too as a wontfix.

Yeah. It's dead.