Bug An active amygdala is detected as an active noncombat forcer

[Danre98]

Reproduced in r29075 by eating a Formica e Pepe and taking the combat-forcing option. Mafia prints

Preference noncombatForcerActive changed from false to true

Not essential info:
This doesn't fully explain the seemingly-random flip-flopping I saw (like below) with the pref when I was testing a new autoscend feature. So, there might be more buggy behavior, but maybe fixing this bug will fix the flip-flopping.

Preference noncombatForcerActive changed from true to false

equip acc3 Möbius ring
Preference noncombatForcerActive changed from false to true

 

[Ryo_Sangnoir]

Flip-flopping is going to be because when it loads the charpane, as amygdala is an adventure modifier, it sets it to true, but when it loads api.php, as it doesn't appear in the noncomforcers JSON array, it sets it to false.

Fix is to change the charpane parsing to only set true if it's a NC forcing adventure modifier, not any.

 

[Ryo_Sangnoir]

r29076.