Bug - Fixed After ascension kol thinks you are an astral spirit until restart.

[taltamir]

[COLOR=olive]
> ash my_class()[/COLOR]

Returned: Astral     Spirit
primestat => Muscle

this happens on all my account after ascending in r20482. Tested in both greygoo and kolhs paths.

`refresh all` does not fix this
visiting the char sheet does not fix this
restarting mafia does fix it.
closing mafia (to get back to the launcher) and then logging in again from the launcher does fix it.

 

[MCroft]

Out of band, taltamir tells me he ascended from class 'X' to class 'X'.

My theory is that it's caused by r20482. It probably needs some additional condition to check that the character isn't freshly ascended, but I can't see exactly what that would be.

public static final void setClassName( final String classname )
{
	KoLCharacter.classname = classname;
	String originalClassType = KoLCharacter.classtype;
	String newClassType = KoLCharacter.getClassType();

	// We can use == on Strings since getClassType will return a
	// constant string. It would be cleaner to have an enum.
	if ( originalClassType != newClassType )
	{
		KoLCharacter.classtype = newClassType;
		KoLCharacter.tripleReagent = KoLCharacter.classtype == KoLCharacter.SAUCEROR;

		if ( KoLCharacter.classtype == KoLCharacter.ASTRAL_SPIRIT )
		{
			return;
		}

		// If we have an actual class, we have a mainstat.
		// Reset concoction mainstat gains to reflect this.
		ConcoctionDatabase.resetConcoctionStatGains();

		// Allow or disallow special fight actions
		FightRequest.initialize();
	}
}

 

[MCroft]

Suggested Patch: Moved setting the class type above the if statement, to allow this to work for same class ascensions.

There are other ways to fix this, which may make more sense.

View attachment ascending_to_same_class.patch

 

[taltamir]

i will test r20481 as soon as one of my accounts ascends. which is probably going to be 2 days from now

 

[taltamir]

tested on several accounts. can confirm the issue is limited to r20482 and is not found in r20481
also independently confirmed by others on discord

 

[Veracity]

Try 20483

 

[taltamir]

Try 20483

it works now. thank you

BTW did this only fix thinking class is astral spirit, or did it also address how "refresh all" does not refresh your class?