Feature - Implemented Adding Clover Coverage to Jenkins

[fewyn]

Not really sure it's happened a couple times since I've started with openclover on it. Researching it now.

 

[fewyn]

Yes it looks like it crashed part way through the testing and resumed it when I woke up and restarted the service.

 

[fewyn]

Not finding anything useful in the logs at the moment, what I've done in the mean time is setup a cron task which will check ci.kolmafia.us every 10 minutes for a 503 error and if it sees it it will automatically restart Jenkins.

 

[gausie]

I think the eventual plan is to put commit all of this Jenkins config to the repo (via a Jenkinsfile)

 

[fewyn]

It is, as soon as this is stable enough to be used regularly I'll get it committed and it should be good from there.

 

[fronobulax]

In the realm of nits, https://ci.kolmafia.us/job/Kolmafia Pipeline/clover/dashboard.html includes

Code coverage 1,773 classes, 26,546 / 201,465 elements​

0.1317648313.2%

That second line is missing a space, before the 13.2 The other percentages as similarly displayed.

 

[heeheehee]

Hm, fewyn, did your CORS fixes from yesterday end up getting wiped? It was working earlier...

 

[fewyn]

Hm, fewyn, did your CORS fixes from yesterday end up getting wiped? It was working earlier...

You will want to view it via https://ci.kolmafia.us/job/Kolmafia Pipeline/HTML_20Publisher_20Report/ for some reason the OpenClover report doesn't always seem to be setting the correct CSP.

 

[heeheehee]

Hm, that still doesn't work for me.

 

[fewyn]

Hm, that still doesn't work for me.

Do a hard refresh. Ctrl+F5

 

[heeheehee]

The problem seems to be that the CSP is still borked for the iframe contents (index.html) even though the wrapper is more permissive.

(I've confirmed that disabling caching doesn't address this.)

I can reproduce on the command line with

$ curl -I https://ci.kolmafia.us/job/Kolmafia%20Pipeline/HTML_20Publisher_20Report/index.html
HTTP/1.1 200 OK
Date: Sat, 04 Sep 2021 14:25:34 GMT
Server: Jetty(9.4.43.v20210629)
X-Content-Type-Options: nosniff
Content-Security-Policy: sandbox; default-src 'none'; img-src 'self'; style-src 'self';
X-WebKit-CSP: sandbox; default-src 'none'; img-src 'self'; style-src 'self';
X-Content-Security-Policy: sandbox; default-src 'none'; img-src 'self'; style-src 'self';
Last-Modified: Sat, 04 Sep 2021 14:23:20 GMT
Expires: Sat, 04 Sep 2021 14:23:20 GMT
Accept-Ranges: bytes
Content-Type: text/html;charset=utf-8
Content-Length: 397
Access-Control-Allow-Origin: *

 

[fewyn]

Should be good now... it's showing the correct CSP now.

Except for base64 encoded images.... I'm at a loss why the data: setting isn't working.

 

[heeheehee]

Thanks, works for me now.

I'm unreasonably pleased that if you look at the coverage treemap, there's one big rectangle of green (Parser.java) in a sea of red. I have even more tests for that file coming shortly...