Bug - Fixed 26526 breaks fidoxene tracking

[DanceCommander6]

Upgraded to 26528, started up my CS script. CS script threw as apparently I didn't manage to get my Chocolate Lab to 120 pounds. I open up my relay browser and the Chocolate Lab is at 128 pounds, while Mafia keeps believing it's at 117. The culprit is Fidoxene.

Trying some recent releases, it seems the issue is introduced in 26526. I was able to get 26525 to display the correct 128 pounds for the Chocolate Lab in the client.

 

[gausie]

Looks to be related to the changes to familiar weight calculation in https://github.com/kolmafia/kolmafia/pull/846. @DanceCommander6 this might be a pain but could you post a modtrace familiar weight for both 26525 and 26525 when the issue is happening?

 

[DanceCommander6]

By now I'm quite a bit downstream, but what I've got is a screenshot of 26526 acknowledging it has Fidoxene online but saying the dog weighs 9 pounds. Meanwhile in 26525 `familiar_weight()` returned 20.

 

[gausie]

Ah I see, we never supported Fidoxene, its just that the code that was removed supported it without us intending it to.

 

[gausie]

Ok I've got a fix for this I think.

 

[gausie]

Actively include Fidoxene when calculating familiar weight by gausie · Pull Request #850 · kolmafia/kolmafia

Hopefully fixes https://kolmafia.us/threads/26526-breaks-fidoxene-tracking.27683 This also makes me think: the two places I had to make this change are trying to achieve the same thing (I think) - ...

github.com