New Content - Implemented 2022 New Year Changes

katyarn

Member
  • Clovers: The hermit now offers 11-leaf clovers which grant an intrinsic effect Lucky! on use. 11-leaf clovers combine the effects of ten-leaf clovers and semi-rare adventures into what are termed Lucky adventures. Some clover/semi-rare adventures are no longer available and their items may be available elsewhere (example: miniature boiler drops from monstrous boiler).
    • The hermit no longer trades ten-leaf clovers.
    • Pill Keeper sunday pill now grants Lucky!
    • Optimal dog now grants Lucky!
    • Lucky Lindy is now size 6 good quality booze and grants Lucky!
    • Fortune cookie grants a ten-leaf clover upon eating.
    • Lucky Pills should still grant a ten-leaf clover upon chewing.
    • Ten-leaf clover recipes are intended to remain the same.
    • Elf farm raffle tickets no longer consume clovers, they are purely random now.
Code:
--------------------
10881    11-leaf clover    477842994    11leafclover.gif    usable    t    0
# Item 11-leaf clover: Gives you good luck
--------------------
--------------------
2693 Lucky! 11leafclover.gif    de95d62abb71d5221ec6c068c1c72626 neutral none
# Effect Lucky!
--------------------
--------------------

  • Semi-rares: There is no more semi-rare counter. Some semi-rare adventures can be encountered with Lucky! such as the Knob Goblin Embezzler.
  • Astral Energy Drinks: Spleen items that grant the same Lucky! intrinsic effect as clovers, 5 toxicity. (Should be a new item ID, but not sure what it is yet)
  • Transcendental Olfaction: Now costs 0 mp (down from 40 mp), limit 3 uses per day, effect lasts across rollover (thanks for the updated info!) or until used on a new target.
  • Softcore Pulls: Can now only pull one of each item per day (total daily limits unchanged from 20).
  • Marmot Moon Sign: Now +1 prismatic resistance (previously randomly dropped a clover).
 
Last edited:

Magus_Prime

Active member
One more trivial update:
December 31, 2021 - Oh also Cannonfire40 wants me to announce that the Demon Name adventures in the Spooky Forest and Haunted Bathroom are now unavailable until after whatever thing happens in there that people care about.
 

heeheehee

Developer
Staff member
  • Transcendental Olfaction: Now costs 0 mp (down from 40 mp), limit 3 uses per day, effect lasts all day (maybe across rollover?) until used on a new target.
I believe this does in fact last across rollover. My session logs from meatfarming today don't contain any casts of olfaction (controlled via autoattack macro), yet my number of garbage tourist encounters are roughly the same as usual (maybe 1-2% lower ratio than usual, but that's probably within margin of error).
 

Veracity

Developer
Staff member
ten-leaf clovers and disassembled clovers are still "usable" to create each other.
We no longer need "clover protection", exactly.:
-> I went to the castle basement, ignored the warning, and did not get a clover adventure.

Using an 11-leaf clover gives you an intrinsic - Lucky!
-> I went to the castle basement, (ignored the clover warning), and got what used to be a the clover adventure.
"You suddenly feel less lucky." It did not say "you lose an intrinsic" or anything, but it did disappear from the charpane.

So, we presumably still need "lucky" protection.
encounters.txt contains both SEMIRARE and CLOVER

Here is a list of locations that (used to) have both a SEMIRARE and CLOVER:

Code:
A Mob of Zeppelin Protesters    CLOVER    Methinks the Protesters Doth Protest Too Little
A Mob of Zeppelin Protesters    SEMIRARE    Methinks the Protesters Doth Protest Too Little
A-Boo Peak    CLOVER    The "Journalist"
A-Boo Peak    SEMIRARE    Oh, <i>There</i> Have it Gone
Cobb's Knob Kitchens    CLOVER    Luck in the Kitchens
Cobb's Knob Kitchens    SEMIRARE    Knob Goblin Elite Guard Captain
Cobb's Knob Laboratory    CLOVER    Believe it or Not
Cobb's Knob Laboratory    SEMIRARE    You Can Top Our Desserts, But You Can't Beat Our Meats
Frat House    CLOVER    Lambda Upsilon Chi Kappa
Frat House    SEMIRARE    Sand in the Vaseline
Frat House In Disguise    CLOVER    Lambda Upsilon Chi Kappa
Frat House In Disguise    SEMIRARE    Sand in the Vaseline
Guano Junction    CLOVER    How I Wonder What You're At
Guano Junction    CLOVER    What Can You Do?
Guano Junction    SEMIRARE    Le Chauve-Souris du Parfum
Hippy Camp    CLOVER    Batty About Fruit
Hippy Camp    SEMIRARE    The Latest Sorcerous Developments
Hippy Camp In Disguise    CLOVER    A Case of the Baskets
Hippy Camp In Disguise    SEMIRARE    The Latest Sorcerous Developments
Itznotyerzitz Mine    CLOVER    Either Ore
Itznotyerzitz Mine    SEMIRARE    7-Foot Dwarf Foreman
Oil Peak    CLOVER    Up From the Ground...
Oil Peak    SEMIRARE    It's a Gas Gas Gas
South of the Border    CLOVER    Forget Not That I am an Ass
South of the Border    SEMIRARE    Filth, Filth, and More Filth
The Castle in the Clouds in the Sky (Basement)    CLOVER    You Never Know What You're Gonna Find
The Castle in the Clouds in the Sky (Basement)    SEMIRARE    Fit and Finish
The Copperhead Club    CLOVER    Where There's Smoke...
The Copperhead Club    SEMIRARE    Where There's Smoke...
The Haunted Ballroom    CLOVER    Forward to the Past
The Haunted Bathroom    CLOVER    That's a Tidy Bowl, Man!
The Haunted Billiards Room    CLOVER    Give me Your Nine
The Haunted Billiards Room    SEMIRARE    A Shark's Chum
The Haunted Kitchen    CLOVER    Nicebox
The Haunted Kitchen    SEMIRARE    Play Misty For Me
The Haunted Library    CLOVER    Dust to Dust
The Haunted Library    SEMIRARE    Like the Sunglasses, But Less Comfortable
The Haunted Pantry    CLOVER    It's Your Lucky Day!
The Haunted Pantry    SEMIRARE    The Pilsbury Doughjerk
The Limerick Dungeon    CLOVER    The Weathered Old Chap
The Limerick Dungeon    SEMIRARE    The Bleary-Eyed Cyclops
The Outskirts of Cobb's Knob    CLOVER    Knob Goblin Luck!
The Outskirts of Cobb's Knob    SEMIRARE    Lunchboxing
The Sleazy Back Alley    CLOVER    Lucky You, Unlucky Hobo
The Sleazy Back Alley    SEMIRARE    In the Still of the Alley
The Spooky Forest    CLOVER    Lucky, Lucky!
The Spooky Forest    SEMIRARE    Blaaargh! Blaaargh!
The Unquiet Garves    CLOVER    Only Dust and a Plaque
The Unquiet Garves    SEMIRARE    A Menacing Phantom
The VERY Unquiet Garves    CLOVER    Rolling the Bones
The VERY Unquiet Garves    SEMIRARE    A Menacing Phantom
Twin Peak    CLOVER    What Kind of Party Is This?
Twin Peak    SEMIRARE    Synecdoche, Twin Peak
Ye Olde Medievale Villagee    CLOVER    A Role In the Hay
Ye Olde Medievale Villagee    SEMIRARE    Clay Is Great, But Leather Is Bether

Here are locations that used to have either SEMIRARE or CLOVER, but not both.

Code:
8-Bit Realm    SEMIRARE    Some Bricks Do, In Fact, Hang in the Air
A Maze of Sewer Tunnels    SEMIRARE    C. H. U. M. chieftain
An Octopus's Garden    SEMIRARE    moister oyster
Art Class    SEMIRARE    Fran&ccedil;ois Verte, Art Teacher
Battlefield (Cloaca Uniform)    SEMIRARE    Prior to Always
Battlefield (Dyspepsi Uniform)    SEMIRARE    Prior to Always
Battlefield (No Uniform)    SEMIRARE    Prior to Always
Burnbarrel Blvd.    SEMIRARE    A Tight Squeeze
Camp Logging Camp    CLOVER    Oot to Lunch
Chemistry Class    SEMIRARE    Mrs. K, the Chemistry Teacher
Cobb's Knob Barracks    SEMIRARE    Knob Goblin Elite Guard Captain
Cobb's Knob Harem    SEMIRARE    Hands On
Cobb's Knob Menagerie, Level 2    SEMIRARE    Rokay, Raggy!
Cobb's Knob Treasury    SEMIRARE    Knob Goblin Embezzler
Elf Alley    SEMIRARE    What a Tosser
Exposure Esplanade    SEMIRARE    Cold Comfort
Lair of the Ninja Snowmen    SEMIRARE    Not Quite as Cold as Ice
Lemon Party    CLOVER    Lemon Party Slot
Madness Reef    SEMIRARE    Dragon the Line
Outskirts of Camp Logging Camp    CLOVER    Best Served Cold
Pandamonium Slums    SEMIRARE    It's The Only Way To Be Sure
Shop Class    SEMIRARE    X-fingered Shop Teacher
The "Fun" House    CLOVER    The Boxer
The Ancient Hobo Burial Ground    SEMIRARE    Flowers for You
The Batrat and Ratbat Burrow    SEMIRARE    How Does He Smell?
The Black Forest    CLOVER    What the Cluck?
The Brinier Deepers    SEMIRARE    The Haggling
The Briny Deeps    SEMIRARE    Deeps Impact
The Bugbear Pen    CLOVER    Faux Fur Pas
The Castle in the Clouds in the Sky (Ground Floor)    SEMIRARE    Ahead of the Game
The Castle in the Clouds in the Sky (Top Floor)    SEMIRARE    All The Rave
The Cheerless Spire (Level 1)    CLOVER    Take Stuff From Work
The Cheerless Spire (Level 2)    CLOVER    Lucky Breaktime
The Cheerless Spire (Level 3)    CLOVER    Can't Serum
The Cheerless Spire (Level 4)    CLOVER    Mime On, Mime In, Mime Out
The Cheerless Spire (Level 5)    CLOVER    Always Be Miming
The Dark Elbow of the Woods    SEMIRARE    It's The Only Way To Be Sure
The Dark Heart of the Woods    SEMIRARE    It's The Only Way To Be Sure
The Dark Neck of the Woods    SEMIRARE    It's The Only Way To Be Sure
The Dive Bar    SEMIRARE    Razor, Scooter
The Goatlet    SEMIRARE    Natural Selection
The Hallowed Halls    SEMIRARE    Through the Locking Glass
The Haunted Boiler Room    SEMIRARE    Bram the Stoker
The Haunted Conservatory    CLOVER    Sweeping Up the Skeleton Bones
The Haunted Gallery    CLOVER    With a Clatter
The Haunted Storage Room    SEMIRARE    full-length mirror
The Heap    SEMIRARE    Juicy!
The Hidden Park    SEMIRARE    Two Sizes Too Small
The Hidden Temple    SEMIRARE    Baa'baa'bu'ran
The Icy Peak    CLOVER    Encino Penguin
The Knob Shaft    CLOVER    Junction in the Trunction
The Mer-Kin Outpost    SEMIRARE    A Drawer of Chests
The Oasis    CLOVER    Some Things Never Change
The Obligatory Pirate's Cove    SEMIRARE    Yo Ho Ho and a Bottle of Whatever This Is
The Poker Room    CLOVER    A Motor in your Head
The Primordial Soup    CLOVER    Beginner's Luck
The Purple Light District    SEMIRARE    Maybe It's a Sexy Snake!
The Red Zeppelin    SEMIRARE    Red Fox
The Roulette Tables    CLOVER    The Luckiest Gambler
The Smut Orc Logging Camp    CLOVER    S&M 4-EVER
The Spectral Pickle Factory    CLOVER    Wouldn't You Like to be a Pickle Too?
The Spooky Gravy Burrow    CLOVER    Stage Fright
The Valley of Rof L'm Fao    SEMIRARE    Bad ASCII Art
The Wreck of the Edgar Fitzsimmons    SEMIRARE    Camera On, James
Thugnderdome    CLOVER    Gno More Mr. Gnice Guy
Tower Ruins    CLOVER    I've Gotta Crow
Vanya's Castle Chapel    SEMIRARE    The Time This Fire
Whitey's Grove    SEMIRARE    Monty of County Crisco

Considering that the Haunted Boiler Room used to have Bram the Stoker as a SEMIRARE encounter, giving the monstrous boiler a miniature boiler (with lucky?) seems unfortunate.

I just tested: got Lucky! and went to the boiler room and got Bram the Stoker.

We need LUCKY encounters in encounters.txt and "lucky protection".
Well, a fair amount of spading needed here.
 

Veracity

Developer
Staff member
I had On the Trail (effect 311) yesterday.
Today, it is not on my charpane.

I looked at the previously reported effect for the new On the Trail:

Code:
--------------------
2694    On the Trail    snout.gif    519edacbd99d93658cc2ef05bd6baefb    neutral    none
# Effect On the Trail
--------------------

Be vewwy, vewwy quiet. You're hunting wabbits. And by "wabbit" I mean "garbage tourist."

And that is, in fact, what my "olfactedMonster" property says.

I went to the Icy Peak.
I encountered a Knott Yeti.
Skill dropdown says:

Code:
<option value="19" picurl="snout" >Transcendent Olfaction (3 uses left today)</option>

I used the skill and got:

You take a deep breath, allowing your opponent's scent to fill your entire being.
On the Trail
You acquire an intrinsic: On the Trail

And now it is in my charpane.
I went and olfacted a garbage tourist. decorated charpane looks like this:

Intrinsics:
snout.gif
On the Trail (garbage tourist, ∞)

Code:
> ash have_effect( $effect[ On the Trail ] )

Multiple matches for "On the Trail"; using "[2694]On the Trail". (char 23 to char 36) Clarify by using one of:
$effect[[331]On the Trail]
$effect[[2694]On the Trail]
Returned: 2147483647

> ash have_effect( $effect[ [331]On the Trail ])

Returned: 0

> ash have_effect( $effect[ [2694]On the Trail ])

Returned: 2147483647

I'll submit a PR with the bare minimum for this:

- (Add 11-leaf clover item)
- add Lucky! intrinsic
- add (new) On the Trail intrinsic
- comment out the old On the Trail effect, so ASH can use $effect[ On the Trail ] without ambiguity
- change EffectPool.ON_THE_TRAIL to have the new effect ID

I consider it to be a KoL bug to not display the On the Trail intrinsic in the charpane if you had the old status effect before rollover. But I cannot fix that. Once you cast it again, things should work as expected.
 

Veracity

Developer
Staff member
Note that tracking daily usage is still needed - and places that check if ON_THE_TRAIL is active
 

Veracity

Developer
Staff member
Damn it. I just made changes and pushed them not from a branch - and I can't make a pull request. Does this mean that I have force pushed them without review? I am sorry!
 

VladYvhuce

Member
Apparently, not all is yet set up for the new Lucky system. According to the forums, they're going to start working on things like the pillkeeper on Monday.
 

Veracity

Developer
Staff member
Ha ha. The CharPaneDecoratorTest is specifically testing how an olfacted monster shows up.
On The Trail is now an intrinsic.
PR, if committed will disable them. https://github.com/kolmafia/kolmafia/pull/436

The test and expected HTML differ because one allows olfaction to be uneffected.
I have modified the tests and expected results to put On the Trail into the Intrinsics section and decorate it in the expected way for an intrinsic.
Trying it out now.
 

Rinn

Developer
31337 scrolls don't drop a hermit script anymore on first use and they as expected still give ten-leaf clovers on subsequent uses.
 

Veracity

Developer
Staff member
I have modified the tests and expected results to put On the Trail into the Intrinsics section and decorate it in the expected way for an intrinsic.
Trying it out now.
No joy. Not understanding why.

Did submit a pull request to fix how we decorate intrinsics; we previously put a span around the parenthesized duration of any type of an effect, but for intrinsics, short-circuited before putting in the /span to close it.
 

Veracity

Developer
Staff member
The test and expected HTML differ because one allows olfaction to be uneffected.
More than that: to be actually correct, On the Trail needed to be in the Intrinsics section, not the Effects section.
So far, no joy in correcting the HTML.
 

Veracity

Developer
Staff member
OK, my open pull request fixes the CharPaneDecorator test.
Turns out that even though there were intrinsics in the input data, it didn't actually test decorating intrinsics in the charpane.
 

Veracity

Developer
Staff member
I have another PR in to remove the concept of clover protection - and to recognize that the hermit has 11-leaf clovers, not ten-leaf clovers.
 

Veracity

Developer
Staff member
Huh. I see that gausie has a draft PR which has all the stuff I did for clovers - and also a whole mess of stuff to deal with semirares, fortune cookies, ENCOUNTER and SEMIRARE encounter types becoming LUCKY encounters (module ongoing spading.)

My PR is a strict subset of his - and removes clover warnings, fixes the hermit (and breakfast), clover protection, and so on.
Which is all stuff that is useful right now, without spading.

Rinn approved my PR late last night. I have since added a few tweaks - including responding to his comment that the Lemon Party Slots are confirmed to require Lucky! rather than a clover.

I'm going to use my "special administrator powers" to merge in my PR.

Sorry, gausie; you will now have a merge to do. The good news is that probably a dozen files will no longer need to be part of your PR.
 
Top