Bug - Fixed 11093 breaks alternate tavern commands
- Thread starter Theraze
- Start date
Tavern Quest (explore)
What is Tavern Quest (explore) supposed to do? I thought it was supposed to visit the unexplored squares in the Tavern Basement (until all were explored) but what it is doing for me in r11309 is fighting rats in the same square. Error with my expectations? Some preference that got hosed? Something I should report as a Bug?
Thanks.
What is Tavern Quest (explore) supposed to do? I thought it was supposed to visit the unexplored squares in the Tavern Basement (until all were explored) but what it is doing for me in r11309 is fighting rats in the same square. Error with my expectations? Some preference that got hosed? Something I should report as a Bug?
Thanks.
Thanks. Wasn't sure whether it was a Bug or operator expectation error.
BladeLight
Member
Tavern Baron Finding
It keeps going on to the same spot over and over and over...
It keeps going on to the same spot over and over and over...
Merged.
I was looking at this today but did not make any progress. I'll keep chipping away at it but wouldn't mind if someone else figured it out first.
Theraze
Active member
Well this:
is what mafia currently uses to find the next square. The adventure value is set above to
I mean, we COULD hack out the adventure section, but the way it current works, it just does the default adventure type for "explore next" and since 11093 set your default adventure to be the faucet, it just hard-broke tavern exploration.
Easiest fix would either be reverting 11093 so that exploration just works again, or if Veracity wants to retain her efficiency in rat farming the fastest way to enable that would probably be adding a new virtual adventure location, similar to the Hidden City's automatic/encounter types, for explore/faucet.
Code:
while ( ( goal == TavernManager.FAUCET && faucet == -1 ||
goal == TavernManager.BARON && baron == -1 ||
goal == TavernManager.FIGHT_BARON && baron == -1 ||
goal == TavernManager.EXPLORE && unexplored != -1 ) &&
KoLmafia.permitsContinue() &&
KoLCharacter.getCurrentHP() > 0 &&
KoLCharacter.getAdventuresLeft() > 0 )
{
// TavernRequest will visit the next unexplored square
RequestThread.postRequest( adventure );
Code:
// If the goal has not yet been found, then explore
KoLAdventure adventure = AdventureDatabase.getAdventure( "Tavern Cellar" );Easiest fix would either be reverting 11093 so that exploration just works again, or if Veracity wants to retain her efficiency in rat farming the fastest way to enable that would probably be adding a new virtual adventure location, similar to the Hidden City's automatic/encounter types, for explore/faucet.
1) I would like auto-adventuring in the Tavern Cellar to repeatedly hit the faucet. Even though there is not currently a PVP mini that rewards that, I believe that is the correct thing to do.
2) I would like the menu bar and cli commands that say find the baron or explore the rest of the cellar to do the expected thing.
Reverting the submit that enabled the first at the expense of the second will enable the second at the expense of the first.
It should be possible to have both. I'll look at it, by and by.
2) I would like the menu bar and cli commands that say find the baron or explore the rest of the cellar to do the expected thing.
Reverting the submit that enabled the first at the expense of the second will enable the second at the expense of the first.
It should be possible to have both. I'll look at it, by and by.
I see
in there, so it looks like there's still a script running (though I can't tell what script). On the other hand, if it's aborting, why is mafia still trying to adventure?
Theraze
Active member
That's an unconditional trigger caused by nemesis. However, being in a zombie run, there are no hitmen, and it shouldn't be going active... though it would still be parsed and would show in the debug log...
If I'm reading this correctly, it's evaluating false. No abort.
If I'm reading this correctly, it's evaluating false. No abort.
Code:
<IF>
<OPER &&>
<OPER contains>
<CALL item_drops>
<VARREF> null
<VALUE item [secret tropical island volcano lair map]>
<OPER ==>
<CALL item_amount>
<VALUE item [secret tropical island volcano lair map]>
<VALUE int [0]>
<SCOPE>
<TYPES>
<VARIABLES>
<FUNCTIONS>
<COMMANDS>
<CALL abort>
<VALUE string [You were beaten up by the last hitman - aborting]>
Executing top-level commands
if
Test: ( ( item_drops() contains "secret tropical island volcano lair map" ) && ( item_amount() == 0 ) )
Operator: &&
Operand 1: ( item_drops() contains "secret tropical island volcano lair map" )
Operator: contains
Operand 1: item_drops()
Param #1: null
Param #1: null
Param #1: "lastEncounter"
[NORMAL] <- "lastEncounter"
Entering function get_property
Function get_property returned: The Tavern Cellar
[NORMAL] <- "The Tavern Cellar"
Entering function to_monster
Function to_monster returned: none
[NORMAL] <- "none"
Entering function item_drops
Function item_drops returned: aggregate int [item]
[NORMAL] <- aggregate int [item]
Operand 2: secret tropical island volcano lair map
[NORMAL] <- "secret tropical island volcano lair map"
<- false
[NORMAL] <- false
<- false
[NORMAL] <- false
[NORMAL] <- false