Liguinetta
New member
Small file size (719 kB) and won't open.
Yep, it appears that anything above 10032 is not fully there due to, most likely, a compiling error somewhere along the line.
package net.java.dev.spellcast.utilities does not exist
[javac] D:\dloads\KoLMafiaUpdates\kolmafia\lib\net\java\dev\spellcast\utilities\ActionPanel.java:44: package net.sourceforge.kolmafia.swingui.listener does not exist
[javac] import net.sourceforge.kolmafia.swingui.listener.ThreadedListener;
As I suspected... there's LOTS of compile errors that somehow weren't noticed when building.
i would like to note that r10038 also don't work
No offense, but checking in code that doesn't compile is incredibly sloppy.
I'm sure that you've never created a new file and forgot to check it in to version control. Especially when there are 80 other existing files with changes in them, as part of the change set.
Yeah. Incredibly sloppy.
I'm not sure there is a file missing: src\net\sourceforge\kolmafia\swingui\listener\ThreadedListener.java already exists.Considering that the file missing from 10033 hasn't been checked in yet, that is completely expected.
<antcall target="compile-folder">
<param name="folder" value="${lib}" />
</antcall>
<antcall target="compile-folder">
<param name="folder" value="${src}" />
</antcall>
Update: This is what happened. Should be fixed in 10040.Since src references lib and lib references src I don't think compile order is going to change anything. Given the separation criteria I think the core problem is that something in lib requires src to compile. Not knowing why things were done, I would refactor things so that lib could compile when src was not present. IMHO. YMMV
To answer this particular question, the reason they were separated is because people were having trouble compiling (there's a lot of files to compile and by default, Ant runs out of memory) and they didn't want to have to change their ANT_OPTS. So, I thought separating KoLmafia code from third party library code would help reduce the number of files since nothing native to a third-party library will depend on anything in KoLmafia.I don't really understand the reasons why lib and src are separate, so I don't want to be the one to merge them. However, I believe that might resolve the issue. Would that mess anything up? The alternative would be to replicate the ThreadedListener file within lib.