Page 2 of 2 FirstFirst 1 2
Results 11 to 17 of 17

Thread: Milk of Magnesium nerfed

  1. #11
    Senior Member
    Join Date
    Apr 2019
    Posts
    112

    Default

    you can't stack, since the previous charge is overwritten

    ascension would be very improbable, but I guess it's untested so far...

  2. #12
    Senior Member
    Join Date
    Oct 2017
    Posts
    445

    Default

    r19682 now asks "are you sure you want to eat without milk" if you try to eat magical sausage without drinking milk of magnesium first.
    However, magical sausages do not trigger milk of magnesium new functionality.

    Today I did the following in order
    tried to eat a magical sausage, warned by mafia, said no to not eat.
    drink milk
    eat 22 magical sausages
    eat extra greasy slider with salad fork = triggered +5 adv from milk

    I have no idea if you can still get Got Milk from the genie. I removed milk of magnesium as a source for that, but left in the code in the Item Manager to give food an extra adventure per size if the effect is active.
    Originally Posted by Veracity View Post
    You can't get it from genie anymore
    Last edited by taltamir; 01-05-2020 at 03:17 PM.

  3. #13
    Developer Veracity's Avatar
    Join Date
    Mar 2006
    Location
    The Unseelie Court
    Posts
    12,384

    Default

    I think this is fixed. I didn't remove the obsolete code for Got Milk, but I don't care.

  4. #14
    Senior Member
    Join Date
    Apr 2018
    Posts
    339

    Default

    I think this is fixed. I didn't remove the obsolete code for Got Milk, but I don't care.
    Originally Posted by Veracity View Post
    Should the extant issues be treated as bugs with the new implementation, rather than wrinkles in the process of making the new implementation?

    For instance, should I file a bug report for the magical sausage issue mentioned earlier?
    Last edited by Saklad5; Yesterday at 08:19 PM.

  5. #15
    Developer Veracity's Avatar
    Join Date
    Mar 2006
    Location
    The Unseelie Court
    Posts
    12,384

    Default

    Near as I can tell, it didn't nag before was because the sausage has fullness 0 and that was never greater than the number of turns of the effect you had left.
    Which is to say, there was no special check for the sausage. Wiki says that Got Milk "Does not work with sushi or with Hobopolis marketplace food."
    Wiki doesn't say a word about which items the new Got Milk doesn't work on.

    Wiki also says "An unused charge of milk of magnesium will persist through rollover, but using another milk of magnesium without first using the charge will overwrite it instead of stack."
    That would imply we should have a non reset-at-rollover property which says you have an unused charge, and when we detect the milk message after consumption, reset that.
    If you ate with yesterday's charge, can you drink more today?

    I guess this is not done. Except for me; what we have now suits my needs, so I am unlikely to spend more time on it.

  6. #16
    Senior Member
    Join Date
    Apr 2018
    Posts
    339

    Default

    Near as I can tell, it didn't nag before was because the sausage has fullness 0 and that was never greater than the number of turns of the effect you had left.
    Which is to say, there was no special check for the sausage. Wiki says that Got Milk "Does not work with sushi or with Hobopolis marketplace food."
    Wiki doesn't say a word about which items the new Got Milk doesn't work on.

    Wiki also says "An unused charge of milk of magnesium will persist through rollover, but using another milk of magnesium without first using the charge will overwrite it instead of stack."
    That would imply we should have a non reset-at-rollover property which says you have an unused charge, and when we detect the milk message after consumption, reset that.
    If you ate with yesterday's charge, can you drink more today?

    I guess this is not done. Except for me; what we have now suits my needs, so I am unlikely to spend more time on it.
    Originally Posted by Veracity View Post
    I suspect it does not trigger for size 0 food. As for the weird non-reset-at-rollover behavior, that seems a lot like a bug, particularly with regards to being allowed to waste a milk of magnesium the next day. I personally don't think it is worth implementing that until we get confirmation that is actually meant to happen.

    Either way, you have no obligation to do anything, especially if you don't need the changes. Should I submit a patch for not asking with size 0 food to this thread?

  7. #17
    Developer Veracity's Avatar
    Join Date
    Mar 2006
    Location
    The Unseelie Court
    Posts
    12,384

    Default

    Try revision 19696 (untested) which is coded in such a way that we could replace the "size 0" check with something more complicated, (like excluding sushi), should we desire.

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •