Page 1 of 2 1 2 LastLast
Results 1 to 10 of 17

Thread: McClusky File not being correctly auto-created

  1. #1
    Junior Member
    Join Date
    Jun 2019
    Posts
    17

    Default McClusky File not being correctly auto-created

    When automating during ronin at the hidden office building in the hidden city, KoLMafia v19.7 is not correctly creating the McClusky file after finding all 5 pages and the binder clip. I'm not sure why.
    From the CLI:
    Request 15 of 25 (HiddenCity: The Hidden Office Building) in progress...

    [838] The Hidden Office Building
    Encounter: Working Holiday
    Encounter: pygmy witch accountant
    Round 0: ClubbingKelp wins initiative!
    Round 0: ClubbingKelp casts BAKE!
    Round 1: pygmy witch accountant takes 35 damage.
    Round 1: You lose 31 hit points
    Round 1: ClubbingKelp casts CHOP!
    Round 2: pygmy witch accountant takes 75 damage.
    Round 2: pygmy witch accountant takes 33 damage.
    Round 2: ClubbingKelp wins the fight!
    You gain 148 Meat
    You acquire an item: bone abacus
    You acquire an item: adder
    You acquire an item: McClusky file (page 5)
    Verifying ingredients for McClusky file (complete) (1)...
    Creating McClusky file (complete) (1)...
    You are currently in a choice.
    After Battle: You gain 16 Beefiness
    You gain a Muscle point!
    After Battle: You gain 22 Enchantedness
    After Battle: You gain 9 Sarcasm
    Mafia stopped automation and told me "You are currently in a choice", even though I wasn't. Examining my inventory reveals the unassembled file. What's going on here? I'm currently on an Avatar of Jarlsberg path, but I remember this happening on other paths before.

  2. #2
    Senior Member
    Join Date
    Feb 2010
    Posts
    1,094

    Default

    It auto-created properly for me, yesterday, with 19.7 r19551 in a Kingdom of Exploathing run. I won't be in a position to test it again for another day or two.
    Last edited by Magus_Prime; 09-20-2019 at 10:25 AM.

  3. #3
    Junior Member
    Join Date
    Jun 2019
    Posts
    17

    Default

    I looked through my session log, and it says something different from the CLI:
    [838] The Hidden Office Building
    Encounter: Working Holiday
    Took choice 786/3: Fight pygmy witch accountant
    choice.php?whichchoice=786&option=3&pwd
    Encounter: pygmy witch accountant
    Round 0: ClubbingKelp wins initiative!
    Round 0: ClubbingKelp casts BAKE!
    Round 1: pygmy witch accountant takes 35 damage.
    Round 1: You lose 31 hit points
    Round 1: ClubbingKelp casts CHOP!
    Round 2: pygmy witch accountant takes 75 damage.
    Round 2: pygmy witch accountant takes 33 damage.
    Round 2: ClubbingKelp wins the fight!
    You gain 148 Meat
    You acquire an item: bone abacus
    You acquire an item: adder
    You acquire an item: McClusky file (page 5)
    After Battle: You gain 16 Beefiness
    You gain a Muscle point!
    After Battle: You gain 22 Enchantedness
    After Battle: You gain 9 Sarcasm
    So I'm wondering if gaining the last page of the McClusky file from a combat entered through the Working Holiday choice adventure causes it to not be created correctly.

  4. #4
    Developer Veracity's Avatar
    Join Date
    Mar 2006
    Location
    The Unseelie Court
    Posts
    12,253

    Default

    Which version of KoLmafia are you using? You say 19.7, but which revision? Are you using a daily build?

    There are 3 paths to getting all the ingredients:

    1) Get all 5 accountants (apartment building, office building) before you take the choice and get the binder clip. My session log from 2019/09/01:

    Code:
    [525] The Hidden Office Building
    Encounter: Working Holiday
    Took choice 786/2: Get boring binder clip
    choice.php?pwd&whichchoice=786&option=2
    You acquire an item: boring binder clip
    
    Use 1 boring binder clip + 1 McClusky file (page 1) + 1 McClusky file (page 2) + 1 McClusky file (page 3) + 1 McClusky file (page 4) + 1 McClusky file (page 5)
    You acquire an item: McClusky file (complete)
    2) You get the boring binder clip and then fight the 5th accountant. My session log from 2019/09/09:

    Code:
    [535] The Hidden Office Building
    Encounter: Working Holiday
    Took choice 786/2: Get boring binder clip
    choice.php?pwd&whichchoice=786&option=2
    You acquire an item: boring binder clip
    
    [536] The Hidden Office Building
    Encounter: pygmy witch accountant
    Round 0: Veracity wins initiative!
    ...
    Round 3: Veracity wins the fight!
    ...
    You acquire an item: McClusky file (page 5)
    
    Use 1 boring binder clip + 1 McClusky file (page 1) + 1 McClusky file (page 2) + 1 McClusky file (page 3) + 1 McClusky file (page 4) + 1 McClusky file (page 5)
    You acquire an item: McClusky file (complete)
    After Battle: You gain 22 Strongness
    After Battle: You gain 16 Magicalness
    After Battle: You gain 35 Cheek
    3) You take the choice and get the 5th accountant. My session log from 2019/07/01:

    Code:
    [709] The Hidden Office Building
    Encounter: Working Holiday
    Took choice 786/3: Fight pygmy witch accountant
    choice.php?pwd&whichchoice=786&option=3
    Encounter: pygmy witch accountant
    Round 0: Veracity wins initiative!
    ...
    Round 5: Veracity wins the fight!
    ...
    You acquire an item: McClusky file (page 5)
    
    Use 1 boring binder clip + 1 McClusky file (page 1) + 1 McClusky file (page 2) + 1 McClusky file (page 3) + 1 McClusky file (page 4) + 1 McClusky file (page 5)
    You acquire an item: McClusky file (complete)
    After Battle: You gain 15 Muscleboundness
    After Battle: You gain 13 Mysteriousness
    After Battle: You gain 28 Smarm
    So, at one point, all three paths worked correctly.
    However, in the last week or so, I have been changing a lot of stuff in choice processing, and I started seeing inappropriate "you are in a choice" messages - even from places where it shouldn't have cared, as opposed to this case, where it is actually creating an item and does care.

    Yesterday, I submitted revision 19554 which tries to make sure that when a choice redirects to a fight (like this one), it immediately clears the "I am in a choice" flag.

    Which is to say, I probably broke this, but I also probably fixed it.

  5. #5
    Developer Veracity's Avatar
    Join Date
    Mar 2006
    Location
    The Unseelie Court
    Posts
    12,253

    Default

    I suppose a way to test:

    1) Fight 4 accountants in the apartment building and office building.
    2) Run away from any others until you get the binder clip
    3) Run away from any others until you take the Working Holiday choice again, and fight an accountant.
    4) See if creates the McClusky File (complete), as expected.

    That would slow down a run by up to 5 turns (an extra cycle in the office building).
    I say "up to" because bad luck could have forced you into the extra cycle anyway, due to lack of accountants, as it did for me on 2019/07/01...
    Ph'nglui mglw'nafh Cthulhu
    R'lyeh wgah-nagl fhtagn.

  6. #6
    Junior Member
    Join Date
    Jun 2019
    Posts
    17

    Default

    Which version of KoLmafia are you using? You say 19.7, but which revision? Are you using a daily build?
    Originally Posted by Veracity View Post
    Sorry, I knew I should have specified which revision, but I couldn't seem to find the option in the menu which told me what revision I was on. >_>

    There are 3 paths to getting all the ingredients:

    1) Get all 5 accountants (apartment building, office building) before you take the choice and get the binder clip. My session log from 2019/09/01:

    2) You get the boring binder clip and then fight the 5th accountant. My session log from 2019/09/09:

    3) You take the choice and get the 5th accountant. My session log from 2019/07/01:

    So, at one point, all three paths worked correctly.
    Originally Posted by Veracity View Post
    Yeah, it's weird how you got that third choice and got the fifth page and it created the file for you, but not for me. ?_?

    However, in the last week or so, I have been changing a lot of stuff in choice processing, and I started seeing inappropriate "you are in a choice" messages - even from places where it shouldn't have cared, as opposed to this case, where it is actually creating an item and does care.

    Yesterday, I submitted revision 19554 which tries to make sure that when a choice redirects to a fight (like this one), it immediately clears the "I am in a choice" flag.

    Which is to say, I probably broke this, but I also probably fixed it.
    Originally Posted by Veracity View Post
    Well, I'll grab the latest revision then, and hope it doesn't come up again. Thanks!

  7. #7
    Junior Member
    Join Date
    Jun 2019
    Posts
    17

    Default

    I suppose a way to test:

    1) Fight 4 accountants in the apartment building and office building.
    2) Run away from any others until you get the binder clip
    3) Run away from any others until you take the Working Holiday choice again, and fight an accountant.
    4) See if creates the McClusky File (complete), as expected.

    That would slow down a run by up to 5 turns (an extra cycle in the office building).
    I say "up to" because bad luck could have forced you into the extra cycle anyway, due to lack of accountants, as it did for me on 2019/07/01...
    Originally Posted by Veracity View Post
    I could try that on my next run, sure. Does Mafia still try to auto-create the file even if I'm manually adventuring?
    I'm definitely not a run optimizer, so 5 turns doesn't matter an iota to me. =P

  8. #8
    Developer Veracity's Avatar
    Join Date
    Mar 2006
    Location
    The Unseelie Court
    Posts
    12,253

    Default

    I always adventure manually in the Relay Browser. All the (working) examples I showed you are aut-creation after adventuring in the Relay Browser.

  9. #9

    Default

    Last run, creating the McClusky File worked, but creating the Talisman o' Namsilat failed: I beat Ron, then Shen later, and got the "You are currently in a choice." failure message. After that, I made a meat paste and a "create Talisman o' Namsilat" worked to create it.

    That was on the 17th, and some of the changes since then might have fixed it.

  10. #10
    Developer Veracity's Avatar
    Join Date
    Mar 2006
    Location
    The Unseelie Court
    Posts
    12,253

    Default

    Fascinating.

    I've always done Shen first - and gotten his half of the Talisman as the result of a choice - and then Ron - and gotten his half after the fight. You just did that in the opposite order.

    Looking at the code, I can't see how that would have ever worked. The autoCreate happens in result processing - when we notice that we have picked up the talisman piece - but we are still definitely handling the choice during result processing.

    Which is to say, this is not a new bug.

    I'll look in to creating the Talisman in postChoice2.

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •