Page 6 of 31 FirstFirst ... 4 5 6 7 8 16 ... LastLast
Results 51 to 60 of 307

Thread: Two Crazy Random Summer

  1. #51
    Developer Veracity's Avatar
    Join Date
    Mar 2006
    Location
    The Unseelie Court
    Posts
    11,990

    Default

    Yeah. Maimizer works for equipment, but any item which grants an effect does not work yet.

    We need to look at all items which grant an effect (potions and consumables), and for those effects, list exactly those items as granting it, and for all other effects that list an item (not a skill) as granting it, remove the items.

    I've been hoping somebody else would step up and take that on, since I am Way Busy, but if nobody does it before this weekend, I'll take a look.

    tl;dr: maximizer works if you look only at equipment.

  2. #52
    Developer fronobulax's Avatar
    Join Date
    Feb 2009
    Location
    Central Virginia, USA
    Posts
    4,425

    Default

    I have code that copies the file from SourceForge to the data directory. It will silently override any file that is already there but hopefully people that are generating files to help spade will remember to save their results. My big issue right now is my code is not handling line endings the way I would hope. Programmer error, I'm sure, but my Gold Standard is that a diff utility that cares about white space believes the file SVN downloaded into my KoLmafia source and the one I downloaded to /data are identical. That's not happening.

    Assuming I can resolve that before I go AFK for the weekend, I've added a couple of methods to TCRSDatabase.java because they seem to me to fit there. I can check it in when I think it works or I can post a patch for you to apply locally and submit when you are happy. I want to believe you might have a preference as to how you control the merge and possible conflicts.

    My failure to post or commit means I'm still debugging.

  3. #53
    Junior Member
    Join Date
    Oct 2018
    Posts
    15

    Default

    I've ran TCRS derive for Sauceror-Marmot. I'm not sure if it has everything, the file has 10041 lines if that's correct? Anyway, here it is if that's useful to anyone. Happy to do more of these as I ascend into other classes if you're building up a store of them.

    TCRS_Sauceror_Marmot.txt

  4. #54
    Developer fronobulax's Avatar
    Join Date
    Feb 2009
    Location
    Central Virginia, USA
    Posts
    4,425

    Default

    I'm afk for a bit so I'm going for a patch and not a commit.

    Methods to fetch the remote file or fetch and then load. Parameterless versions only work if you are in TCRS.

    Successfully fetched the five files that are in SVN now. Two of those files use MAC EOL and three use Windows. I decided that using the OS that was running to specify the EOL was better than requiring the checked in files to use one standard and forcing the local file to be byte by byte identical. Results are byte by byte identical on Windows when the checked in versions were committed from Windows (and identical, ignoring whitespace in all cases).

    As written will only try and fetch a particular file once per session. Fetched file will silently overwrite what is there so players doing spading will need to be careful.

    I did not write any code that calls to to load the files. I figured there might be feedback. If I do add such code then I would fetch and load during login (using the parameterless version) and find somewhere in the new path from ascension processing to do the same. I am wondering about exposing the fetch command in ash. Scripter can get file for class and sign of their choice and then use the existing load if that is what they want

    TCRSDatabase.java.patch
    Well, thank you.
    Originally Posted by Veracity View Post

  5. #55
    Senior Member
    Join Date
    Apr 2018
    Posts
    302

    Default

    Successfully fetched the five files that are in SVN now. Two of those files use MAC EOL and three use Windows. I decided that using the OS that was running to specify the EOL was better than requiring the checked in files to use one standard and forcing the local file to be byte by byte identical. Results are byte by byte identical on Windows when the checked in versions were committed from Windows (and identical, ignoring whitespace in all cases).
    TCRSDatabase.java.patch
    Originally Posted by fronobulax View Post
    When you say “MAC EOL”, are you referring to Unix line endings (LF)? That isn’t specific to macOS, though decades ago it used to use “CR” for line endings. When people say “Mac line endings”, they usually refer to that, but I have no idea why anyone would be creating files with them.

    I just analyzed all the line endings for files with “.txt” or “.java” as an extension in KoLmafia’s source code. With the exception of “GMartRequest.java” and “SpantRequest.java”, absolutely everything uses Unix line endings.

  6. #56
    Senior Member Crowther's Avatar
    Join Date
    Nov 2006
    Posts
    1,477

    Default

    Thanks for the progress so far. This isn't very important, but I noticed an issue with clownosity. I started the nemesis quest in ronin, because I'm burning turns to get out of ronin and I noticed mafia does not see my clownosity. The normal equipment for clownosity works unchanged and it is listed in the descriptions. For example, the "polka-dot bow tie" aka "huge medical-grade bow tie" says "Makes you look 75% clowny", however mafia doesn't seem to see it
    Code:
    > tcrs check 2233
    
    name = huge medical-grade bow tie
    size = 0
    quality =
    modifiers = 'HP Regen Min: 7, HP Regen Max: 10'

  7. #57
    Developer
    Join Date
    Apr 2010
    Posts
    5,129

    Default

    We should probably change our handling to recognise that message, and maybe have clowny rather than clownosity, if the game has it that way. So maybe have 25, 50, 75 clowny percent.

    Would also stop us using bitmaps for it, which wouldn't hurt.

  8. #58
    Developer Veracity's Avatar
    Join Date
    Mar 2006
    Location
    The Unseelie Court
    Posts
    11,990

    Default

    Revision 19238 handles all "cafe" consumables - food and booze that are immediately consumed when you buy them. These all have negative item numbers.
    Speakeasy drinks should have been created like this, but were given real item numbers - unlike the other clan consumable, hot dogs.

    Every such consumable has TCRS descriptors which modify its size and quality, although none except the the Gnome and Canadia purveyors of booze and food, respectively, will be usable in a Standard TCRS run.

    Unfortunately, both of those cafes have items # -1, -2, and -3. All other food or booze consumables for not overlap in item # space. If they didn't overlap, I could simply add them to, for example, TCRS_CLASS_SIGN.txt files. Instead, I added two more files: TCRS_CLASS_SIGN_cafe_booze.txt and TCRS_CLASS_SIGN_cafe_food.txt

  9. #59

    Default

    I noticed you did not have any pastamancers in your data set so I created a forum account and ascended into one. I'm not the fastest ascender but I will try to provide them as I am able.
    Attached Files

  10. #60
    Developer Veracity's Avatar
    Join Date
    Mar 2006
    Location
    The Unseelie Court
    Posts
    11,990

    Default

    I'm afk for a bit so I'm going for a patch and not a commit.
    Originally Posted by fronobulax View Post
    Thanks! I pulled this in and adjusted it, now that we have three files per path to fetch and load.

    I'll be ascending into a new TCRS run today, so will try to get the "new ascension" fetching in place. Since it will be a new class/sign combo, I'm thinking it will detect the failure to fetch and will offer to do a "derive + save + apply" right then.

    The "fetch + load + apply" needs to happen at login time. And again, if the fetch fails, should offer to do "derive + save + apply".

    I got rid of the combined "fetch + load" since as I mentioned, there is a choice to be made by the user after the "fetch" succceeds or fails.

    And "reset" (which will undo "apply" needs to be written and done when you free the king or log in (in case you logged out and logged in without resetting KoLmafia).

    I've ran TCRS derive for Sauceror-Marmot. I'm not sure if it has everything, the file has 10041 lines if that's correct? Anyway, here it is if that's useful to anyone. Happy to do more of these as I ascend into other classes if you're building up a store of them.
    Originally Posted by King Dave View Post
    Thanks! We now have three files needed for each class:

    TCRS_CLASS_SIGN.txt
    TCRS_CLASS_SIGN_cafe_booe.txt
    TCRS_CLASS_SIGN_cafe_food.txt

    We can operate without the last two - although the Canadia or Gnome cafe items will not be adjusted correctly - but if you publish new data, get all three, please.

    (If you are on a path which only has the first, "tcrs derive" will get just the new stuff and "tcrs save" will save them)
    I noticed you did not have any pastamancers in your data set so I created a forum account and ascended into one. I'm not the fastest ascender but I will try to provide them as I am able.
    Originally Posted by One Sided Die View Post
    Thanks!

    Revision 19239 for all of the above
    Ph'nglui mglw'nafh Cthulhu
    R'lyeh wgah-nagl fhtagn.

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •