Page 4 of 4 FirstFirst ... 2 3 4
Results 31 to 37 of 37

Thread: 2019 IOTM Fourth of May Cosplay Saber

  1. #31
    Developer
    Join Date
    Apr 2010
    Posts
    5,134

    Default

    r19399 - Untested

  2. #32
    Senior Member soolar's Avatar
    Join Date
    May 2015
    Posts
    110

    Default

    Going by my testing the change seems to be making the saber always considered ineffective instead. I think the code needs to be something more like

    Code:
    if ( this.effective )
    {
    	if ( id != ItemPool.FOURTH_SABER ) // Always uses best stat, so always considered effective
    	{
    
    		if ( KoLCharacter.getAdjustedMoxie() >= KoLCharacter.getAdjustedMuscle() &&
    			weaponType != WeaponType.RANGED &&
    			( !EquipmentDatabase.isKnife( id ) || !KoLCharacter.hasSkill( "Tricky Knifework" ) ) )
    		{
    			slot = auxSlot;
    		}
    		if ( KoLCharacter.getAdjustedMoxie() < KoLCharacter.getAdjustedMuscle() &&
    			weaponType != WeaponType.MELEE )
    		{
    			slot = auxSlot;
    		}
    	}
    }
    Since I think the
    Code:
    slot = auxSlot;
    is what's telling it to only consider that for the off-hand slot.

  3. #33
    Developer
    Join Date
    Apr 2010
    Posts
    5,134

    Default

    r19411 - tested this time!

  4. #34
    Junior Member
    Join Date
    Dec 2010
    Posts
    10

    Default

    It seems to me that _saberMod might not be cleared at rollover - I just logged in for the first time today and it's value is 3. This is r19417, though, but I didn't notice any relevant-sounding recent changes. Also, I'm in a TCRS run in case that matters.

  5. #35

    Default

    It seems to me that _saberMod might not be cleared at rollover - I just logged in for the first time today and it's value is 3. This is r19417, though, but I didn't notice any relevant-sounding recent changes. Also, I'm in a TCRS run in case that matters.
    Originally Posted by apologue View Post
    The saber's modifiers are parsed when you log in to see if it is already configured. It wouldn't surprise me if its TCRS mods happen to match the strings checked for.

  6. #36
    Junior Member
    Join Date
    Dec 2010
    Posts
    10

    Default

    Sounds like a plausible explanation. The saber's modifiers in Seal Clubber / Opossum TCRS are

    Moxie +15
    Moxie +20%
    Serious Stench Resistance (+3)

    so I suppose the last one is considered a match for Serious Resistance to All Elements (+3).

  7. #37
    Junior Member
    Join Date
    Jun 2010
    Posts
    20

    Default

    if (get_property("_saberMod") == "0")
    {
    visit_url("main.php?action=may4");
    visit_url("choice.php?pwd&whichchoice=1386&option= OPTION NUMBER");
    }

    OPTION NUMBER:
    1 = regen 15-20 mp
    2 = +20 ML
    3 = +3 all res
    4 = +10 lbs
    5 = skip it

    edit: the space between the equals sign & OPTION NUMBER, is a quirk of the forum and shouldn't be there.

    and, more simply, you can use

    if (get_property("_saberMod") == "0")
    {
    visit_url("main.php?action=may4");
    run_choice(OPTION NUMBER);
    }

    instead.
    Originally Posted by AlbinoRhino View Post
    Also found you can pare this down to a CLI command, and thus also an unconditional mood:
    main.php?action=may4; choice #

    Helps for those with the Mac struggle, I spent a good while trying to figure a way to write an .ash file before deciding to tinker in CLI.
    Last edited by Arashmin; 08-17-2019 at 04:29 PM.

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •