Revision 232 removes Gingerbread City from being automatically installed - and, in fact, imported into the script at runtime. Instead, this script treats it like any of the other External Scripts that it can invoke: if you configured VMF to use the script and have the appropriate IOTM, it will be invoked via "call", rather than by calling an internal function.
The only required External scripts which ARE automatically installed - and imported at compile time - are vprops, vcon, and Garden Harvester.
This revision also changes the timeout for consulting 3 times with Madame Zatara to be 5 minutes, waiting 5 seconds at a time. The normal case, when CheeseFax is at home in BAFH, will finish in 20 seconds, but if he is out distributing faxes some of the time, we won't give up for 5 minutes, which should be plenty, even right after rollover. I hope.
Here's the comment I put in about external scripts:
Note that I tell you what the optional scripts are named in the Script Manager - so you can find them to install - as well as the kolmafia.us forum thread pertaining to the script. Also, mostly for my own reference, the directory in KoLmafia's "svn" directory where that script is installed.
// * External Scripts *
// Required scripts which are are installed automatically
// vprops Veracity's property management library
// vcon Veracity's consumable library
// Garden Harvester Veracity's Garden Harvester
// The following scripts are optional. If they are installed and this
// script is configured to use them, they will be invoked as needed
// Here are the script name (as seen in the Script Manager), the forum
// thread describing it, and the repo in your "svn" directory
// Veracity Scripts:
// Beach Comb Veracity's BeachComber
// Spacegate Veracity's Spacegate
// Gingerbread City Veracity's Gingerbread City
// Ezandora scripts:
// Detective School Detective Solver
// TimeSpinner Far Future
// Kremlin's Greatest Briefcase KGBriefcase
// Bastille Battalion Bastille
Some those scripts have VMF configuration and if you enable the script, at validation, we require them to be installed.
Some have no configuration needed (Detective Solver, for example) and we don't check if they are installed at validation time.
1) List all optional scripts as svn dependencies, which will install them all, whether or not you have the prerequisites (IOTM) to use them.
2) Or for all external scripts, provide a configuration property to say whether they should be used, and fail validation if they are not installed.
3) Or for all external scripts for which you have the prereqs (IOTM), if you have not installed (and configured) them, give a warning (suggestion) to install and configure the script.
Not that you will see validation warnings, unless you watch the validation phase of the script - which is the very first stage of execution.
(By the way, I'll be releasing an Arrrbor Day script, which VMF will require - and therefore install - but not import. Considering I won't be able to test it for anoth 86 days, I haven't started writing it yet. )