Bug - Fixed more skill data corrections

Hibernate effect number of turns

> ash to_effect($skill[hibernate])

Returned: Well-Rested

> ash turns_per_cast($skill[hibernate])

Returned: 0

This should be 5


Skill type for Dismiss Pasta Thrall, Summon Minion, Lure Minion

# Type can be:
# 0 (Passive)
# 1 (Noncombat item summon)
# 2 (Noncombat healing)
# 3 (Noncombat non-shruggable effect)
# 4 (Noncombat shruggable effect)
# 5 (Combat)
# 6 (One-at-a-time Noncombat Song)
# 7 (Combat/Noncombat healing)
# 8 (Combat/Passive)
# 9 (One-at-a-time Noncombat Expression)


Dismiss Pasta Thrall = 1 (summon)
This is probably better as an effect, #3 or #4

Summon Minion = 3 (effect)
This should be #1 (summon)

Lure Minion = 2 (heal)
This should be #1 (summon)

Certainly agree on Dismiss Pasta Thrall, as that doesn't summon an item. Type 3 would cause the fewest other issues I think (and match Spirit of Nothing). We don't have a remove effect type at present.

Summon Minion should probably be type 2, as it is (effectively) an MP heal, it certainly isn't an item summoning spell. When you have Summon Horde it should be type 3, but is always single cast, rather than turns/cast, as it is turns/100 meat in a single cast. So if someone felt so inclined, it could be added to the skill checking code to work out which it is.
Lure Minion is right at type 2, as (effectively) an MP heal. It doesn't summon items.
You are probably right strictly on Hibernate, but I'm not keen to add a 'feature' that results in it being easier to burn a load of adventures. By not having a turns per cast value it will only be cast once. It is mainly a full heal. The same applies to Spirit Vacation.

Its been a while since I have played ZM, so excuse my forgotten knowledge.

I was thinking that Summon Minion 'summons' zombies, so it should be type 1. But zombies as MP would make it a heal. But the higher level effect would make it an effect (as it is). <shrug> Maybe best to just keep it as is.

Lure minion is also a summon zombie skill... which could be a heal if you think if zombies as MP. I see the reasoning here now. Thanks.

As for Hibernate, I don't understand why a turns_per_cast of 0 makes is less likely that someone would cast multiple of this. If I do a 'cast 5 hibernate' will it only cast once?

ckb said:

As for Hibernate, I don't understand why a turns_per_cast of 0 makes is less likely that someone would cast multiple of this. If I do a 'cast 5 hibernate' will it only cast once?

Click to expand...

Imagine hitting maxcast on Hibernate, and burning all your turns immediately by accident ! At the moment it'd burn 1 adventure.

Darzil said:

Imagine hitting maxcast on Hibernate, and burning all your turns immediately by accident ! At the moment it'd burn 1 adventure.

Click to expand...

Looking at Transcendent Al Dente, which also has a cost of 1 Adventure, this returns a turns_per_cast() of 10. For the reasons given above this should probably be 0.
also: skill Simmer is cost 1 Adventure.


> ash turns_per_cast($skill[Transcendent Al Dente])

Returned: 10

> ash turns_per_cast($skill[Simmer])

Returned: 10

r14316

As the number of adventures used is now displayed, I care less about accidents, and have put the proper number of turns of the effects in.

I've also added adv_per_cast( skill ) and soulsauce_per_cast( skill ) so these can be handled in scripts without special handling.

r14317 changed function names to adv_cost and soulsauce_cost.