Search results

  1. I

    Feature - Implemented Hallowiener Encounter tracking, how you can help!

    Fair enough. Removed them and marked the PR as ready
  2. I

    Feature - Implemented Hallowiener Encounter tracking, how you can help!

    Alright, all tests are added. Beach Bucks and funfunds are no longer tracked as they are reoccurring. The code for the friar trio still exists and should still work if the encounters are fixed. I think the options for what to do about that before the PR can be marked as ready are.. A. Remove...
  3. I

    New Content - Implemented Miniature Crystal Ball tracking post January 10th 2022 changes

    Replying to this thread instead of making a new one. So I've taken it as a personal offense that crystal ball tracking isn't as reliable as it should be, and made a PR here So the real question is, what should we do with ambiguous monster names? I'm actually referring to specifically these...
  4. I

    Feature - Implemented Hallowiener Encounter tracking, how you can help!

    Cool. But yeah, turns out funfunds is an occuring adventure. But not sure if beach bucks is the same. Occurs every 50 adventures apparently. Added the other 4 along with their tests.
  5. I

    Feature - Implemented Hallowiener Encounter tracking, how you can help!

    "hallowienerFunFunds"
  6. I

    Feature - Implemented Hallowiener Encounter tracking, how you can help!

    I have a PR here which trains hallowiener encounters. So you can tell if you've already gotten the volcoino this ascension, or the beachbucks, or the NC in the bat cave. Etc. Now, because I'm "very smart". I made this PR even though I do not have a Haunted Doghouse. Because I can't generate...
  7. I

    Feature Adding "stop" for scripts to gracefully stop

    Bumping this instead of creating a new thread. I think for a simpler implementation of this, we could add "stop" command. And a [STOP] button next to the "[REFRESH]" button in the mafia GUI in the side pane. Using either of these will set a preference asking the script to stop "stopRequested"...
  8. I

    Feature Pull's are limited to 1, don't present option to pull multiple items

    With the 2022 change of pulls being limited to 1 of each type, mafia has mostly adjusted. But one remaining thing is the pulls option. The option to pull multiples should only appear when you have unlimited pulls. This option only appears when you have multiple items, immediately pulling when...
  9. I

    Bug - Fixed Possible Consumables Database Error prevents Mafia from starting

    https://github.com/kolmafia/kolmafia/pull/1159
  10. I

    Feature Replace pwd hashes in debug log with generic string

    After some mild investigation, the attack vector requires that the debug log is shared immediately after the requests is made, and that the user does not make another http request so that the AWS load balancer cookie remains unchanged. Obfuscation of the session id should invalidate that...
  11. I

    Feature Replace pwd hashes in debug log with generic string

    Every so often a naive user shares their log in discord, and someone has to tell them to relog. An hour ago was the last time.
  12. I

    Feature Replace pwd hashes in debug log with generic string

    All too often (Probably every other month) you see someone sharing their debug log without realizing they want to hide their pwd hashes. Only a few people would want said hash in their logs to be the real thing, and to date I don't recall a situation where I want the real hash in my logs. So...
  13. I

    Feature ASH location_accessible function.

    Ah just had a thought. Will this properly account for when a relay script tells you if you can adventure there or not? Quick example, say I have a script that tells me to go to this location for whatever reason, maybe its something I run in gCLI, something I run in a relay script. It has a...
  14. I

    Feature - Implemented Prevent multiple instances of kolmafia from accessing the same account

    Just to clarify because I think there's some confusion going on. I'm not talking about raising or lowering the instance limit. Just a sanity check to prevent one account being logged into with multiple instances. So the instances are not fighting over who is logged in.
  15. I

    Feature ASH location_accessible function.

    Haunted bedroom is still incorrect, reported that I could adventure there immediately after I received the necklace from writing desk. Obviously, I couldn't. I still needed to deliver my necklace, then talk to them on the second floor. js canAdventure(Location.get("The Haunted Bedroom"))...
  16. I

    Feature - Implemented Prevent multiple instances of kolmafia from accessing the same account

    Sometimes in a fortnight I misclick and accidentally log into an account that's running turns on my second instance of mafia. This obviously does not go well. We have a session lock, I'm not sure if its possible to make another session lock for a username. So when you have an account selected...
  17. I

    Bug - Won't Fix Second floor is not available, when canAdventure says it is

    This test and a few others, appear to be wrong. This also looks wrong. For starters, as soon as the 5th writing desk is defeated. Second floor does not become available. We still need to talk to the ghost. After talking to the ghost, our spookyraven necklace disappears. Second floor can now be...
  18. I

    Bug - Fixed Price calculation incorrect for gift shop purchases

    I see a 5% discount which reduces "All-Purpose Flower" from 2k to 1.9k But when using CLI to buy a "All-Purpose Flower" it'll grab the sweatpants, claim it's buying at 1.8k. Spend 1.9k and restore my pants. Equipping my pants and going there manually shoes it is at 1.9k. Using a holiday coupon...
  19. I

    Feature - Implemented Hide uy] from relay mall search if the store is in forbiddenStores

    https://github.com/kolmafia/kolmafia/pull/1088
  20. I

    Feature - Implemented Hide uy] from relay mall search if the store is in forbiddenStores

    How about this? Just a red background, and a title attribute. Having the whole line red is a bit obtrusive.
Back
Top