Search results

  1. I

    Feature - Implemented ash my_clan()

    heh, that's funny - I had the same problem with the bafh script in this thread - http://kolmafia.us/showthread.php?3620-VIP-Hopping!-Quick-clanhop-to-BAfH-for-all-VIP-room-goodies! It's a minor regex tweak to get the right ID, I'm sure you've figured it out but see the thread if you don't want...
  2. I

    New Content - Implemented Olympic-Sized Swimming Pool

    I'm taking a stab at finishing this feature off. I'm posting in the hopes of getting others to sanity check my logic before I get too far down a coding dead-end. The core of the remaining issue, I believe, is the ability for kolmafia to detect the item drop - making the calls to do the dive...
  3. I

    Bug - Fixed Fails to recognize breaking apart BRICKO equipment

    Well, I think this turned out to be super-easy, as lostcalpolydude did all the heavy lifting. At face value, everything seems to work - going back and forth between using bricko bricks and using the bricko items now correctly zeros out to no net change in item gain. I'm concerned I'm missing...
  4. I

    Bug - Fixed Fails to recognize breaking apart BRICKO equipment

    I've been poking at this, and should have a patch later today. My approach basically matches what you suggested above, lostcalpolydude - I will add a UseItemRequest.parseBricko function to call when the uri matches breakbricko, that then looks basically like the code you put in above. This seems...
  5. I

    VIP Hopping! Quick clanhop to BAfH for all VIP room goodies!

    :) Bet you thought you were done with this one. I also found a bug with the "return" command - the origin clan wasn't being parsed properly because of the new PVP Allegience section displayed. It was matching that first, and thus thought I was already "home" because my PVP Allegience matched the...
  6. I

    VIP Hopping! Quick clanhop to BAfH for all VIP room goodies!

    I dug into the script, and it looks like there are two bugs: - goto_clan should only kmail bumcheekcity if the call is to access the bafh clan. - goto_clan shouldn't recurse if it just failed getting into a clan. see below for an (untested) attempt to fix the issue...
  7. I

    Feature - Implemented add mp regen and hp regen maximizer keywords

    Well, 2 points: - I don't believe adding one more item to the huge list is going to be the straw that broke the camel's back, and indeed there's value there in spelling out the possible options. (hence me prolonging this thread... :)). - I do really believe that for the average user, the...
  8. I

    Feature - Implemented add mp regen and hp regen maximizer keywords

    heh, indeed - you were, up until now. I had the same questions, and voila! Itch scratched. That being said, though - lostcalpolydude, Catch-22's comment is exactly why I recommend including "hp regen" in the default list of modifiers - that's essentially the entirety of the documentation for...
  9. I

    Feature - Implemented add mp regen and hp regen maximizer keywords

    Er, what? No? The current list (at least, what's in defaults.txt, you may have maximized that yourself in the past so it's saved) had only mp regen, or at least the "old" way - ".5 mp regen min, .5 mp regen max". The point of the patch was to replace that with just "mp regen" (and "hp regen") to...
  10. I

    Feature - Implemented add mp regen and hp regen maximizer keywords

    Shrug. Fair enough, it's not a very useful maximizer command since as soon as you've perm'd cocoon, you'll never care about HP regen again, but I'd still recommend including it for completeness's sake. Out of curiosity, why not? Just didn't want to make the default maximizer list any larger?
  11. I

    Feature - Implemented add mp regen and hp regen maximizer keywords

    I was always puzzled by the fact that "mp regen" didn't work as a maximizer option, and you had to put in "0.5 mp regen min, 0.5 mp regen max". So, I got curious, and started poking at the code. That made sense, then, as to why - but as I poked at it further, it looked pretty trivial to just add...
  12. I

    Bug - Won't Fix KoLmafia thinks Travoltan Trousers reduce the meat cost of FDKOL items

    I bet it's at a store level, and this isn't a normal "meat" store, it's a hybrid, and thus not using the trousers discount logic. :) But what do I know.
  13. I

    Bug - Fixed kolmafia failing to login/open

    er, what? http://en.wikipedia.org/wiki/HTTP_cookie#Domain_and_Path - "path" is not a cookie, it's an attribute of the cookie setting the context path for which the cookie is valid. you can basically ignore it for these purposes, but don't set/pass back a "path" cookie. Otherwise, sure, go ahead...
  14. I

    Bug - Fixed kolmafia failing to login/open

    heh. you're welcome, but turns out I didn't - Catch-22 is correct, Veracity won with her commit powers. :) No big deal, glad it's working again.
  15. I

    Bug - Fixed kolmafia failing to login/open

    Veracity just committed the changes - wait a bit for the hourly build of r11172 or later, and you'll be all set. Or you can download the source and build it from scratch, but if you're asking how to apply a patch, you're far better served waiting a bit for the auto build...
  16. I

    Bug - Fixed kolmafia failing to login/open

    Ah? out of curiosity, how come? I'm not a java developer at all, so happy to learn better ways. I figured the pattern matching was more "future proof", although to be fair, the format of a HTTP cookie is standard. I.e., if the kol devs do go and send the cookies on one line, then it's a...
  17. I

    Bug - Fixed kolmafia failing to login/open

    Hmm. further testing looks good for me, so far - indeed, wireshark says I'm sending the right 2 cookies (now) back to the server. :) Servers are nice and zippy, from a lack of all the kolmafia users right now...
  18. I

    Bug - Fixed kolmafia failing to login/open

    Woot! Done! :) I can login now via kolmafia, via attached patch. In all seriously, please do test a bit further before committing. I did login successfully and poked around a bit, but want to do a bit more testing w/ wireshark to ensure I'm really doing the right things.
  19. I

    Bug - Fixed kolmafia failing to login/open

    heh. well, crap. I bet Veracity wins also, but I'm still going to try...
  20. I

    Bug - Fixed kolmafia failing to login/open

    Yeah, broadly the issue is it's two separate Set-Cookie header lines now, and the call to getHeaderField returns the last one (which doesn't have the PHPSESSID, which means kol doesn't know who we are). I'm writing a patch to parse out both cookies and set them properly. :) We'll see if I get...
Back
Top