Search results

  1. H

    Bug - Fixed appearance_rates(location, false) doesn't take combat modifiers into account

    Should be fixed as of r27633. Let us know if you find any more issues!
  2. H

    Bug - Fixed appearance_rates(location, false) doesn't take combat modifiers into account

    r25983 apparently changed this behavior. Should be an easy enough fix, although it's a little worrying that nobody seems to have noticed in nearly 2 years.
  3. H

    LTF: old IOTM zone scripts:

    https://forums.kingdomofloathing.com/vb/showthread.php?t=186384 Some other strategy comments: 1. Get unlockers (bombs / missiles / ice beam) to access more treasure rooms. 2. Get all the treasure rooms for upgrades, and more creds so you can buy more things in between levels. 3. bombs and...
  4. H

    Bug - Fixed AWOL Hard Drinker causes incorrect inebriety_limit

    r27622 fixes this, at least for me.
  5. H

    Bug - Fixed AWOL Hard Drinker causes incorrect inebriety_limit

    https://github.com/kolmafia/kolmafia/pull/1986
  6. H

    Bug - Fixed AWOL Hard Drinker causes incorrect inebriety_limit

    Ah. Yeah, that is backwards.
  7. H

    Bug - Fixed AWOL Hard Drinker causes incorrect inebriety_limit

    modifiers.txt is appropriately qualified: and have_skill correctly identifies which one I have. I'm pretty sure this is further fallout from https://github.com/kolmafia/kolmafia/commit/7b9441e2fee0ad94ab9e5d4137a0d1ae82e291c3. r27600 is fine, r27601 is broken (after hitting refresh). It was...
  8. H

    Bug - Fixed AWOL Hard Drinker causes incorrect inebriety_limit

    I've noticed on two separate occasions, with two separate scripts (my own and vconsume), that I've been overdrinking (but only on heeheehee). Hard Drinker (Avatar of West of Loathing) is being mistaken for the AoSP skill.
  9. H

    Bug - Fixed $class[none] causes java.lang.NullPointerException

    The root cause is that if this.content == null, then this: public Value get_path() { return DataTypes.makePathValue(getAscensionClass().getPath()); } tries to access getPath() on a null pointer.
  10. H

    Bug - Fixed $class[none] causes java.lang.NullPointerException

    Two relevant pieces: 1. (note the absence of "path") 2. Unexpected error, debug log printed. class java.lang.NullPointerException: Cannot invoke "net.sourceforge.kolmafia.textui.AshRuntime.runtimeException(String)" because "interpreter" is null java.lang.NullPointerException: Cannot invoke...
  11. H

    Feature Functions as first-class objects in ASH

    I believe the traditional (unoptimized) interpreter implements lexically-scoped closures by creating a new scope on each function call (with the parent scope being where the function is defined), which allows you to capture the value of any provided arguments and local variables. Would I be...
  12. H

    Feature Functions as first-class objects in ASH

    Maybe in Java, but that's actually atypical, as far as I'm aware. function makeCounter(a) { // `a` below is bound to the provided function argument return () => a += 1; } > counter = makeCounter(5) () => a += 1 > counter() 6 > counter() 7 Closures have the ability to provide a...
  13. H

    Bug - Fixed Images fail to load and multiple "Unexpected error, debug log printed" when clicking on any link in Relay

    You seem to have a DNS issue (per java.nio.channels.UnresolvedAddressException). Can you visit https://d2uyhvukfffg5a.cloudfront.net/otherimages/leftswordguy.gif in your browser?
  14. H

    Bug - Waiting for Info 1952 Mickey mantle pick in Deck of Every Card crash

    This looks very different from the deadlocks we were seeing. The only notable thread that I saw: "CommandQueueHandler" #138 prio=5 os_prio=0 cpu=196539.00ms elapsed=3659.80s tid=0x00007fbc5c499870 nid=0x28d2 waiting on condition [0x00007fbb6abfc000] java.lang.Thread.State: WAITING...
  15. H

    Bug - Not A Bug Effects stuck at zero turns, cannot continue without re-upping

    These effects are in your current Mood. (You can click on the Mood Setup subtab on the Adventure tab)
  16. H

    Bug - Waiting for Info 1952 Mickey mantle pick in Deck of Every Card crash

    I think this particular failure mode would, since I don't think any of these listeners are setting properties.
  17. H

    Bug - Waiting for Info 1952 Mickey mantle pick in Deck of Every Card crash

    I got timein to succeed locally, although I'm still tweaking the code. I suspect that in general, we need to trigger listener updates on the Swing event dispatch thread, to avoid Swing synchronization from causing deadlocks with preference reads.
  18. H

    Bug - Waiting for Info 1952 Mickey mantle pick in Deck of Every Card crash

    Okay. It turns out even if we move that out of the lock, we still run into issues, since LoginManager.timein() grabs the lock up the stack. I suppose I can make AdventureFrame.updateFromPreferences schedule on the event thread...
  19. H

    Bug - Waiting for Info 1952 Mickey mantle pick in Deck of Every Card crash

    This reproduces even with saveSettingsOnSet set to false. It looks like we're doing UI processing off the Swing Event dispatch thread (CommandQueueHandler is updating models...) which is causing a deadlock between Swing UI updates and preference reads. I made an edit that prints out the...
Back
Top