Search results

I did the second because that seems more in line with how mall searches generally work everywhere else, and I couldn't find any other instances where 0 was hardcoded being passed into getMallPrice(). https://github.com/kolmafia/kolmafia/pull/478

I believe I tracked this down to InventoryManager.priceToAcquire(), specifically this line, if exact is true then 0.0f is passed in to StoreManager.getMallPrice() as the age and that causes the session mall cache to get flushed every call. My thought is that for exactt requests this should...

I had tried to add a gihub action that posted a comment with the code coverage \ specific unit testing results in a PR but it was a giant pain because the normal action workflow for PRs isn't allowed to comment because it's a security concern, and using the correct workflow was more arduous than...

https://kol.coldfront.net/thekolwiki/index.php/Intrinsic_Spiciness This is minor but it does cause miscounting for the community service spell damage test so I may try handling this later.

All these mall searches are from a single call to retrieve_item for a single entendre: Searching for "bottle of tequila"... Search complete. Searching for "fermenting powder"... Search complete. Searching for "cactus fruit"... Search complete. Searching for "double entendre"... Search complete...

It's not complete but here's a wip spading sheet about the clover adventures https://docs.google.com/spreadsheets/d/1TKZ_55PMEaHIQbD5BHr_8LG9oJporu2mEv4NQ92K_v4/edit#gid=2075061290

31337 scrolls don't drop a hermit script anymore on first use and they as expected still give ten-leaf clovers on subsequent uses.

I think the macrofier needs to trim extra whitespace from the macro string, because currently it's checking if the length is not empty before sending it to kol, and since yours resolves to three newlines it's not empty but invalid.

Could this be because the first run never reaches the combination with all the +equip requirements before hitting your maximizer limit?

This is where this happens: https://github.com/kolmafia/kolmafia/blob/b26f260dba8a5904d32fb62e750604d063b575a8/src/net/sourceforge/kolmafia/session/EncounterManager.java#L368

I'd be concerned the the subdomain in that cloudflare url isn't stable. Also all the images seem to still be using the aws url if you log in normally. Maybe this is something that should be parsed from the page source the first time it's needed.

Imo rebasing and force pushing a development branch for a PR is completely fine and I do it all the time to update the branch against the main branch rather than dealing with merge commits.

Older releases are available on GitHub https://github.com/kolmafia/kolmafia/releases. Here's the revision from right before the java 9 change https://github.com/kolmafia/kolmafia/releases/tag/r25711

This being a Java 8 issue doesn't surprise me but that's still weird it wasn't able to read the manifest. Maybe this is a non-issue since we're planning on moving up the minimum version pretty soon anyway.

I cracked open that jar and the manifest looks fine: Manifest-Version: 1.0 Main-Class: net.sourceforge.kolmafia.KoLmafia Build-Revision: 25709 Build-Branch: HEAD Build-Commit: 203da09183f1d00c2f9b2e6392fa252a90870dc8 Build-Jdk: 16.0.1 (AdoptOpenJDK 16.0.1+9) Build-OS: Linux amd64 5.11.0-37-generic

This is for my own tracking, but it's trivial to get the latest release from the GitHub api, so I should be able to add an auto update check on mafia startup like the point releases were doing. I was thinking probably be best to put this behind a global property, but it would also be cool if...

@fewyn is working on the rss feed to get the revision number in there.

hm, okay maybe it's a window thing I was testing on unix. I'll look at it again after work.

Ah yeah if you clone on windows git will use \r\n and shell scripts won't work. I can fix that with .gitattributes so it will be correct regardless of host OS, I'll do that as well tonight.

Yes use the wrapper. Yes, we actually encountered a build issue with the newest version of gradle but I don't remember the details, so the repo uses a slightly older version.. No it doesn't need to be installed. I'll update the gradle build to clean old jars after work today.