Search results

  1. gausie

    Feature - Rejected Mall search/buy results are ordered by quantity & name, ignores advertising budget completely.

    I would have these order from Store 9, Store 9 and Store 5 then 9. Just to avoid numbers changing under our feet. By which I mean, these need to have significant buffers if possible. I really don't like this change.
  2. gausie

    Feature - Rejected Mall search/buy results are ordered by quantity & name, ignores advertising budget completely.

    If they would like us to respect those sorts of things, some sort of mall API would be a good sign. Have marked this as Feature: Rejected.
  3. gausie

    All paths lead to... $path

    my_path_id() isn't going anywhere, but there should now be deprecation messages when using them
  4. gausie

    Feature Tracking zone types for the Cold Medicine Cabinet

    Thanks! That code snippet will not do what you think, but I will fix the issue regardless.
  5. gausie

    All paths lead to... $path

    We'll soon be merging code adding a new enumerated type to ASH (and JavaScript!). A few functions will become redundant (path_name_to_id, path_id_to_name and my_path_id) and you'll see warnings in your GCLI when running code that uses them. I'd like to merge this in around 11 hours (9pm in the...
  6. gausie

    New Content Tiny Stillsuit

    This now works with `drink stillsuit distillate`
  7. gausie

    New Content Tiny Stillsuit

    Not only can I fix it, but I can write a test too!
  8. gausie

    Bug - Fixed _saberForceUses is being set to exactly incorrect values

    And thank you for your PR!
  9. gausie

    New Content Tiny Stillsuit

    It's not a thing yet
  10. gausie

    Bug Sometimes script execution hangs until I visit a page using the Relay browser

    I can't work out why this would be and its hard to reproduce, but if I briefly lose connectivity my scripts will often hang in a fight (and are uninterruptable using the escape key). I realised recently that visiting any page using the relay browser kicks them off again as if nothing happened...
  11. gausie

    Bug - Fixed Recent change broke maximizing with accessory requirement

    Yeah it was my bad. Just a "quick change" that I thought I'd make while doing something else important has caused you and Ryo to have to make 3-4 hotfix PRs for which I am both sorry and embarrassed! I've merged that PR ahead of a test that you could write if you wish because its causing active...
  12. gausie

    Bug JUnit tests are not tested in a random order

    We could run them in order and random order, concurrently
  13. gausie

    Bug Tests on kolmafia using Calendar are implemented incorrectly

    Probably setting TimeZone.setDefault(TimeZone.getTimeZone("UTC")); before will work
  14. gausie

    Bug Tests on kolmafia using Calendar are implemented incorrectly

    I wrote these tests and remember wondering if they'd break in Australia. They were too important not to have at the time though. I'll have to put some thought into them
  15. gausie

    Bug JUnit tests are not tested in a random order

    I don't think this is a design choice of course, we just have a configuration issue
  16. gausie

    Bug JUnit tests are not tested in a random order

    Agreed. I found a test recently that passed despite defective code due to ordering.
  17. gausie

    Bug encountersUntilNEPChoice is not being calculated accurately.

    This has come up before - I just need someone to tell me what the right answer is. And ideally update the wiki!
  18. gausie

    Feature - Rejected Add fallback choice support

    Sadly this is something that will require scripting - specifically using the choice adventure script functionality that comes with the default distribution of KoLmafia
Back
Top