Search results

Somewhere to discuss this bug that has already been acknowledged elsewhere

can_adventure can be "trusted" Maybe we should have a preference to run prepareForAdventure before relay visits

Yeah I think the only mistake was manually reimporting the repo, which means GitHub doesn't actually know what what you have is a fork, even though it essentially is.

Would you like to make a PR on GitHub? We don't really take patches anymore

Ok this and a few other issues I have seen mentioned are handled here: https://github.com/kolmafia/kolmafia/pull/1115

What issues are you having?

Fixed!

https://github.com/kolmafia/kolmafia/pull/1109 is my WIP

@Veracity yeah it turns out we were relying on the action pattern to catch preactions in other places (particularly in ClanLoungeRequest) and those have now broken. I started on a fix but it seems like it might be a big bit of work - how do you want to proceed?

Unless it's something to do with the action pattern change? That debug log is going to be useful - I bet this is it actually.

This could end up being wrong of course but looking at the code change introduced in r26778 it seems impossible to have introduced this bug. Can you provide a debug log of you receiving a fax?

Fixed!

(And this is also now fixed)

Duplicate of this: https://kolmafia.us/threads/ash-location_accessible-function.27836/page-3#post-169734

Bumping this because I missed that @basic lihc had provided steps to reproduce

How odd - I had it happen sometimes but couldn't get it to happen when I actually sat down to debug

I've made a PR for this I think here https://github.com/kolmafia/kolmafia/pull/1093.

I have not done this on purpose (and advise other staff to follow me in this regard), watch this space.

This might be worth just merging, perhaps with a message to the debug log

I'd rather something a little less gaudy - greyed out, struck through that sort of thing. But whatever!