Recent content by gausie

Fixed

To part the curtain a little bit, every familiar has an arenaprize field. Familiars that get a lead necklace have null there, and arena.php deals with that by giving a lead necklace. Tiny Cupid bow deals with it by giving a heart necklace. I'd have to check how bander works but I would guess it...

I think this is a straightforward mistake and we should indeed define familiars' equips as the items they get from the cake-shaped arena

This isn't relevant to what I said but I don't understand where the misunderstanding lies.

Zarq has fixed this in https://sourceforge.net/p/batbrain/code/151/

At the very least, this is promising:

When a skill-granting item is added and removed, we should only add and remove that skill from the "skills you have" (as far as scripts are concerned) if it is a combat-only skill. This hopefully fixes that: https://github.com/kolmafia/kolmafia/pull/2826 I'll run autoscend with it today and see

Yes - and a few mechanics will iterate through the drops in this order in a way that we can see. For example, each grey goose drone will duplicate a single drop. If you have a single drone you will only ever duplicate the first item that drops in order.

I think this is all sorted now, marking as implemented

Fixed

https://github.com/kolmafia/kolmafia/pull/2821

Going to mark as "Not a Bug" for now, if Ryo wants to work out a way to do backwards-compat then he can edit further!

This is a really good first time contribution to the codebase!

Fix is waiting approval. This doesn't actually do anything so don't worry about it too much :)

Solution is to fix BatBrain. Here is your new line 427-430 matcher rng_matcher = create_matcher("\\{.+?,(.+?),.+?}",""); string deranged(string sane) { rng_matcher.reset(sane); while (rng_matcher.find()) sane = sane.replace_string(rng_matcher.group(0),rng_matcher.group(1));