r26951 - Don't cache encoded pref values during tests. by @phulin

Anybody remember why this was done? The description is correct - encoded values are not generated during tests if the file is not going to be saved. There is a comment on the PR about the change improving performance for tests but some casual testing using gradle reported times suggests tests are not running faster with this code. I'm wondering about ripping it out it doesn't seem to be beneficial or necessary.
 
Ryo_Sangnoir said:
Probably due to https://github.com/kolmafia/kolmafia/pull/1286#pullrequestreview-1179878571
Click to expand...


Thanks. I'd say there are some philosophical differences because my quick and dirty measurements seem to show there is no measurable time saved... and it does make Preferences a touch more complicated, but if I decide to make a case for reverting it I will do so when it is the only change and can be the subject of more scrutiny. I'll just stay focused on the other locks and synchronizations. Thanks.
 
You must log in or register to reply here.
Back
Top