As came up in https://github.com/kolmafia/kolmafia/pull/1216
For items with identical names, we prefix with numbers to disambiguate, and return the one with the highest id if there's a question.
For monsters and locations, we name them so that they're unambiguous (e.g. Astronomer (obsolete) / Astronomer or Wartime Hippy Camp / The Hippy Camp). For monsters, also, we have the 3 ninja snowmen or the 3 frat boys.
With items like autumn-aton or locket / Manuel, we can know the actual names of monsters / locations. Should we try to keep to KoL names (perhaps with aliases)?
Also, how should we handle unknown locations / monsters? These are now visible: monsters in the locket and locations in autumn-aton. We register monsters from Manuel, but not from the locket.
One related issue: the property "autumnatonQuestLocation" contains a string for the KoL location name, and therefore doesn't uniquely identify the location.
For items with identical names, we prefix with numbers to disambiguate, and return the one with the highest id if there's a question.
For monsters and locations, we name them so that they're unambiguous (e.g. Astronomer (obsolete) / Astronomer or Wartime Hippy Camp / The Hippy Camp). For monsters, also, we have the 3 ninja snowmen or the 3 frat boys.
With items like autumn-aton or locket / Manuel, we can know the actual names of monsters / locations. Should we try to keep to KoL names (perhaps with aliases)?
Also, how should we handle unknown locations / monsters? These are now visible: monsters in the locket and locations in autumn-aton. We register monsters from Manuel, but not from the locket.
One related issue: the property "autumnatonQuestLocation" contains a string for the KoL location name, and therefore doesn't uniquely identify the location.
Last edited: