Bug - Fixed Where's my pickpocket?

[Bale]

I noticed that it was't stealing with basic combat settings, so I decided to switch to a CCS. with try to steal in my CCS it still wasn't stealing, so I switched to "pickpocket" which used to force the macro command pickpocket even if mafia thought that there was no monster.

I'm an Accordion Thief, so I know I can pickpocket.

Here's my CCS:

[ a.a kill ]
attack with weapon

[ barrrney's barrr ]
try to steal an item
skill entangling noodles
item The Big Book of Pirate Insults
special action
section a.a kill

[ clingy pirate ]
try to steal an item
special action
if hascombatitem cocktail napkin
    item cocktail napkin
endif
section a.a kill

[ default ]
"pickpocket"
special action
section a.a kill

[ global prefix ]
scrollwhendone
if hascombatitem rock band flyers
    skill entangling noodles
    item rock band flyers
endif
if hascombatitem jam band flyers
    skill entangling noodles
    item jam band flyers
endif

Here's my CLI output with macroDebug => true:

[278] Defiled Niche
Encounter: senile lihc
Strategy: C:\KolMafia\ccs\bale-temp.ccs [default]
Round 0: bale wins initiative!
Generated macro:
sub mafiaround
endsub#mafiaround
sub mafiamp
****abort "No MP restoratives!"
****mark mafiampexit
endsub#mafiamp
#mafiaheader
scrollwhendone
if hascombatitem rock band flyers
****while mpbelow 3
********call mafiamp
****endwhile
****if hasskill 3004
********call mafiaround; skill 3004
****endif
****call mafiaround; use 2405
endif
if hascombatitem jam band flyers
****while mpbelow 3
********call mafiamp
****endwhile
****if hasskill 3004
********call mafiaround; skill 3004
****endif
****call mafiaround; use 2404
endif
mark mafiafinal
call mafiaround; attack
goto mafiafinal

Round 1: bale executes a macro!
Round 1: bale attacks!
Round 2: senile lihc takes 58 damage.
Round 2: bale attacks!
Round 3: senile lihc takes 48 damage.
Round 3: bale wins the fight!
Your familiar gains a pound: spartacus!, the 5 lb. Baby Bugged Bugbear
You acquire an item: lihc eye
After Battle: spartacus! reaches intoError: Parse error in famdrops.php line 72 #¿ and hands you an item ¶
You acquire an item: seal-clubbing club
After Battle: spartacus! gives you a weird, lopsided grin. What's weird about it is that you can even tell, considering the ski-mask he's wearing.You gain ¤±You gain «You g¢
You gain 5 Strengthliness
You gain 6 Magicalness
You gain 19 Chutzpah

Requests complete.

 

[Bale]

I cannot say why I thought to try this, but I found a way to make this work which seems to cast illumination on the bug. I changed default to...

[ default ]
#comment
"pickpocket"
special action
section a.a kill

I simply added the pointless comment above pickpocket. Then I get this:

Generated macro:
sub mafiaround
endsub#mafiaround
sub mafiamp
****if     hascombatitem 344
********call mafiaround; use 344
********goto     mafiampexit
****endif
****abort "No MP     restoratives!"
****mark mafiampexit
endsub#mafiamp
#mafiaheader
scrollwhendone
if     hascombatitem rock band flyers
****while mpbelow 3
********call     mafiamp
****endwhile
****if hasskill 3004
********call     mafiaround; skill 3004
****endif
****call     mafiaround; use 2405
endif
if hascombatitem jam band flyers
****while     mpbelow 3
********call mafiamp
****endwhile
****if     hasskill 3004
********call mafiaround; skill 3004
****endif
****call     mafiaround; use 2404
endif
pickpocket
mark mafiafinal
call     mafiaround; attack
goto mafiafinal

NOTE that it still won't steal with basic combat settings! Selecting the pickpocket icon in the special field will not inspire it to pick pockets! I really needed to use a CCS.

 

[Bale]

More light dawns!

The global section is invoked even when combat action is not CCS. I deleted the [global] section from my CCS and then it began stealing normally! For some reason there's an issue with my [global]. All the commands in [global] are built into the macro properly so I know that I didn't do anything wrong there, but there seems to be an issue with the next command after [global] if there is a [global] section.

 

[Darzil]

Is it safe to pickpocket? I seem to recall that without safe Moxie pickpocket won't fire, as it doesn't want to get you beaten up ?

 

[Bale]

Is it safe to pickpocket? I seem to recall that without safe Moxie pickpocket won't fire, as it doesn't want to get you beaten up ?

My moxie was quite safe (you might note that the lihc did not hit me in the first example), but I initially intended to test this by switching to "pickpocket" (with quotes) instead of try to steal since the macro command doesn't care about safe moxie. Anyway, the fact that adding a meaningless comment changes the result implies that moxie was not the issue. There seems to be a problem with KoLmafia's macro building routine.

 

[holatuwol]

Aha, so that's why it was -1. I forgot that it'd increment on the next iteration of the loop. Try r9147.

 

[lostcalpolydude]

Marking this as fixed. Speak up (or change it back) if it's still broken.

 

[Bale]

Thanks for noting this wasn't update. holatuwol definitely fixed it.