Bug Visiting the terrarium manually tricks mafia in to thinking the current familiar is a favorite

[soolar]

I noticed this via ChIT's familiar picker, but did some testing and confirmed it's a mafia issue, not a ChIT issue. My initial suspect was that taking the familiar with me via the terrarium page caused the issue, but my testing confirmed that, while switching familiars via the familiar command in the gCLI does not cause the issue, visiting the terrarium afterwards while that familiar is active does. Fortunately, visiting the terrarium while that familiar is not active will correct the issue, so the scope of this bug is, at most, one false favorite familiar at a time.

 

[Veracity]

FamiliarData.java, when visiting terrarium.

        if (familiarMatcher.find()) {
          current = FamiliarData.registerFamiliar(familiarMatcher, true);
          // There's no indication of whether your current familiar is a
          // favorite or not.  Safest to assume it is:
          current.setFavorite(true);
        }

It's intentional.

If you swap the familiar out via script or the compact side pane, it is still marked as a favorite - which means you can easily return to it, without having to search the cascading menus - until you happen to visit the terrarium manually.

Why is this a problem?