Feature - Implemented Track Heavy Rains skill acquisition

[Bale]

Since a new HR skill item is usually acquired each ascension (up to 3 of each) and it is added to the skill items previous acquired, it would be nice to track them. It is important to note that due to a quirk in the system (described below) it is possible to complete a dozen HR ascensions and still not start with a single lightning milk, therefore heavyRainsPoints contains misleading information. It is quite possible for a character with heavyRainsPoints of 9 to start with only 6 skill items and not have a single lightning milk.

mafia should log current skill items when we are informed of them at the beginning of each ascension:

Encounter: Why Is the World In Love Again?
Took choice 966/1: unknown
choice.php?pwd&whichchoice=966&option=1
You acquire an item: lightning milk
You acquire aquaconda brain (3)
You acquire thunder thigh (2)
You acquire an item: Thor's Pliers
You acquire an item: DNA extraction syringe

Does anyone know if it is possible to get stuck without lightning milk because you haven't been killing enough lightning cows? I'm assuming if your brains and thighs are at 3 each you will get a milk for completing your 7th ascension, but it would be nice to know for sure.

I imagine someone will beat me to it, but if not, when I have three in two things I'm happy to avoid meeting the third thing at all to test this.

You've been beaten to the spading. (Posts 547, 554, 556)

I started with 3 thunder thighs, only filled out thunder thigh skills during a run, then the next run I still had only 3 thunder thighs, nothing else

I tested this theory by getting and using primarily anaconda brains on a run I started with 3 brains and 1 lightning milk. The next run I got three brains, 1 milk, and 1 thigh. So my theory is that you can get an item that's not the most commonly used if you already have three of the most commonly used items as long as you get and use at least one of those items. I'm not surprised that a run that used exclusively thighs would not give milk or brain the next time.

I had 1 of each [milk, thigh, brain] at start of run, have not killed single skill dropper. Next run + lightning milk so theory is not exactly correct.

Apparently if you have three of a starting skill item and it is your most common skill, it will choose one of the others at random. BUT, it will only choose from skills you actually possess. SO, if you start with 3 acquaconda brains and none of the others, you need to get at least 1 thunder or lightning skill in order to get a new skill item next ascension. In other words, if you do not successfully kill a storm cow you will never be able to start the ascension with a lightning milk.

 

[Veracity]

You're trying to delay the new release, aren't you.

It'd be nice to get ... something ... in for this while the new Challenge Path is till relatively young, so that KoLmafia users can enjoy and use it for the duration.

 

[Bale]

You're trying to delay the new release, aren't you.

Sorry. I brought up in the Heavy Rains thread that it would be good to save information about the starting skill items. (Although I conveyed one bit of false information -- ick.) Unfortunately I didn't know the rest of this information until yesterday. It's the rest of that information that makes heavyRainsPoints seem misleading. Personally I think that heavyRainsPoints should be removed from the code in favor of this, but that is up to you.

 

[Veracity]

It's not misleading. It tells you the number of HR ascensions you have completed - which is easy to track and not easily deducible. So, I don't regret putting in the tracking - and I would resist removing it

Unfortunately, it doesn't appear to be predictive of anything. You don't like it? Don't look at it. I'm all for adding scraping skills from what washes up and saving that, for whatever use you can make of it.

FWIW, I just ascended and got one each of each item. Does this mean that I don't need to pay any attention to maxing this or that skill tree - unless I want to force an additional item, as I do for Rain - henceforth? It will always give me an item to advance a skill tree that is not already maxed out?

 

[Bale]

It's not misleading.

It is misleading because heavyRainsPoints has the word "points" in it. That implies you get something, like the other "Points" preferences. If you called it heavyRainsAscensions then it would be accurate. Anyway, it isn't important since I can just take your suggestion not to look at it. It won't bite me, after all.

FWIW, I just ascended and got one each of each item. Does this mean that I don't need to pay any attention to maxing this or that skill tree - unless I want to force an additional item, as I do for Rain - henceforth? It will always give me an item to advance a skill tree that is not already maxed out?

Yup. The somewhat limited spading indicates that if you have even a single skill you are guaranteed get that type of item when the other skill types are maxed out.

 

[Darzil]

Try r14577. Didn't work for me initially, as I hadn't realised that current turns in ascension weren't set until character pane was parsed, which happens after these are acquired. Added setting it to zero in Valhalla, so should work now.

Please test !

Edit - If it works, should we retire heavyRainsPoints ? Maybe anyway as the number doesn't always increment at ascension ?

 

[Bale]

Edit - If it works, should we retire heavyRainsPoints ? Maybe anyway as the number doesn't always increment at ascension ?

I favor retiring it because the number isn't actually useful for anything, but Veracity likes being able to easily know the number of times she has ascended in HR (Does she want one of these for every challenge path?) and it doesn't hurt anything to leave it there.

 

[Veracity]

Oh, remove it.

 

[Darzil]

r14582 removes it.

Has anyone ascended into Heavy Rains since yesterday who can verify the skill tracking works so we can close this ?

 

[Fluxxdog]

If things go well and I manage another 3 day SC, I should be able to verify today. <crossing fingers>

 

[xKiv]

r14582 removes it.

Has anyone ascended into Heavy Rains since yesterday who can verify the skill tracking works so we can close this ?

My pref file from (from my POV) yesterday (that is, I ascended about 3 hours before rollover) has:

heavyRainsPoints=1
heavyRainsStartingLightning=0
heavyRainsStartingRain=1
heavyRainsStartingThunder=0

, which is correct. I would wait for someone to verify at least one another amount of brains and two different amounts of thighs/milks, though, 0 and 1 are not especially convincing samples

 

[Veracity]

I'll ascend later this morning. I should have 1 thunder, 2 rain, and 1 lightning for my rewards.

 

[Veracity]

I'll ascend later this morning. I should have 1 thunder, 2 rain, and 1 lightning for my rewards.

heavyRainsStartingLightning=1
heavyRainsStartingRain=2
heavyRainsStartingThunder=1

Yes.

 

[Fluxxdog]

Same here.

heavyRainsStartingLightning (user, now '3', default '0')
heavyRainsStartingRain (user, now '1', default '0')
heavyRainsStartingThunder (user, now '1', default '0')