Bug - Fixed strange little button flickering problem r12557

[Captain Kirk]

I noticed that in the Item Manager in both the "Food" and "Booze" sections that the "feed ghost" and "feed hobo" buttons were flickering for a fraction of a second from the off to the on state. This is for an account that does not have the familiars. It's off 99.9% of the time. Just caught my eye because of the flashing effect.

 

[Darzil]

What were you doing at the time?

 

[Captain Kirk]

What were you doing at the time?

Nothing really.

 

[Darzil]

Well, it's a bit of a hammer to crack a nut, but I think this patch fixes it.

It appears that every few seconds setEnabled is called for the buttons. The first line in that function sets all buttons to true, then sets ones that shouldn't be enabled to false. If your computer is fast and not doing anything else, you probably won't notice the flash, but if your computer is slow or doing other processing, you probably will notice it.

This patch sets all buttons to false if setEnabled is false, as before, but if setEnabled is true, only sets buttons to true that should be. Result is no flash.

 

[Darzil]

Actually, don't use this patch. The main panel has to also be enabled, and this patch doesn't do that, yet.

This one works better.

 

[Darzil]

Fixed in 12583.