Bug Rollover Effect Duration is no longer a valid modifier

Rinn

Developer
The first failure I have a log for is r28864:

Code:
02:01:14 Maximizer: 10.0 adv, 0.001 rollover effect duration, switch disembodied hand, switch left-hand man, -tie
02:01:14 Unrecognized keyword: rollover effect duration
02:01:14 Unable to meet all requirements via equipment changes.
02:01:14 See the Modifier Maximizer for further suggestions.

The last log I have where this worked was r28859:

Code:
00:33:54 Maximizer: 10.0 adv, 0.001 rollover effect duration, switch disembodied hand, switch left-hand man, -tie
00:33:54 Loading character status...
00:33:54 Maximizing...
00:33:59 14923 combinations checked, best score 570.10
00:34:03 29400 combinations checked, best score 570.10
00:34:03 Putting on Counterclockwise Watch...
00:34:03 Equipment changed.
00:34:03 Putting on green LavaCo Lamp™...
00:34:04 Equipment changed.

So this was introduced somewhere in this range https://github.com/kolmafia/kolmafia/compare/r28859...r28864 my guess is https://github.com/kolmafia/kolmafia/commit/2d863a22e7778b995312303b24156900be5578e0
 
Okay, this is turning out to be trickier than expected: it gets the score right when calculating items for the shortlist, but when it comes to calculating the final values, it doesn't include the duration. Confusing.

Might rearchitect.
 
Last edited:
Back
Top