r26532 - log if KoL's modified familiar weight differs from KoLmafia's by Verac

And I'm already seeing this.

I have a Ghost of Crimbo Cheer with experience of 86 (per api.php)
Normally that would be weight = sqrt(86) = 9 lb.

modtrace says:
---------------------
Quantum Terrarium path = +20
astral pet sweater = +10
Amphibian Sympathy = +5
Daylight Shavings Helmet = +5
---------------------
KoLmafia calculates its modified weaight at 9 + 40 = 49 lbs.
Both the charpan and api.php say it is 42 lbs.

Familiar description says "Shares XP with the other Crimbo Ghosts"

Wiki says:

- shares familiar experience with the Ghost of Crimbo Carols and the Ghost of Crimbo Commerce
- Cannot use familiar equipment: "Ghosts can't wear equipment, it would just fall through."
- Has a maximum base weight of 40 lbs (compared to most familiars that only go up to 20 lbs).

Looking at gear changer, it says there is nothing in the familiar equipment slot.
Looking at Equipment page in Relay Browser and api.php, it says there is an astral pet sweater in that slot.

KoLmafia's modified weight calculation should exclude familiar equipment which current familiar cannot wear.

86 exp = 9 lb. + 20 + 5 + 5 = 39 lb, but KoL says 42 lb.

Where is the extra 3 lb. coming from?
 
More and more interesting. My familiar just gained a pound.

1st api.php: "familiar":"281" "familiarexp":"86" "famlevel":42 "familiarequip":"5040"
2nd api.php: "familiar":"281" "familiarexp":"90" "famlevel":43 "familiarequip":"5040"
 
r26534

9-pound Melodramedary (96 experience, 12,617 kills)
> modtrace familiar weight

type source Familiar Weight Hidden Familiar Weight
Skill Amphibian Sympathy +5.00 = +5.00
Effect Leash of Linguini +5.00 = +10.00


> ash familiar_weight( my_familiar() )
Returned: 9


Familiar weight: KoL = 19 KoLmafia = 13

Seems like it should be 19
 
A 9-pound Melodramedery weighs 9 pounds.
With Familiar Weight +10, its modified weight is 9 + 10 = 19 lbs.
If KoLmafia is displaying the modified weight as anything other than 19 pounds, yeah, that's a problem.
 
Or are you saying the ASH familiar_weight() used to return the modified weight?
Yeah, I think I might have changed that. I can fix it.
 
Mafia was reporting 13 lbs in the main window (wrong)
ASH was reporting base weight of 9 lbs (correctly)
Modtrace was reporting +10 lbs (correctly)

Mafia printed "Familiar weight: KoL = 19 KoLmafia = 13"
 
I believe familiar_weight() has always returned the base weight of familiars.

familiar_weight(fam) + weight_adjustment() = modified weight
 
Still seeing issues in r26535:
Familiar weight: KoL = 24 KoLmafia = 16

@Veracity Note: Refreshing the charpane seems to fix the issue.
 
Fam was a Exotic Parrot. Base weight was 9 lbs, Modtrace Familiar weight was +15. ash familiar_weight( my_familiar() ) Returned: 9

Sorry I don't have more details. If I have time in my next run I'll try to get more info.
 
I am actively experimenting with characters in aftercore and also in-run. Every two days, I am completing a new HC 2-day Quantum Terrarium run - which don't tell you your familiars's actual experience (i.e. base weight) anywhere except api.php, although the modified weight appears in both the charpane and api.php.

And the experience in api.php is definitely not correct all the time. Perhaps it is because they are "borrowed" familiars. I have saved logs showing a familiar with "84 experience" who then "gains a pound" - and now it is "90 experience".

I have a pending PR which might fix things for you.
 
You must log in or register to reply here.
Back
Top