Bug - Fixed pulls_remaining() returns 0 same day as out of ronin

[rlbond86]

Using r10929:

> ash pulls_remaining()

Returned: 0

I just got out of ronin today. Documentation says it should return -1.

 

[lostcalpolydude]

I think the way to fix this is to have KoLCharacter.setRonin() call ConcoctionDatabase.setPullsRemaining( -1 ) when inRonin is false. I can only guess that updating Coinmasters all the time would be wasted processing (since it will be set to -1 a lot with that change), so check for the old and new value being the same and just return in that case. Just in case I'm overlooking some performance issues, I'll wait a day or so before committing that change, in case there's feedback about it.

Edit: Never mind, that would be completely wrong in HC.

 

[lostcalpolydude]

11352.