Bug - Fixed new env() mod fails to evaluate when you don't have an environment

[Bale]

After doing Spelunky I noticed that all my sea gear causes errors in mafia when there's a reason to check them, like using the maximizer. Probably because those locations have no evironment info.

 

[Bale]

This is what I got from maximizing after Spelunkin'

Maximizing (1st time may take a while)...
Expression evaluation error for Mer-kin takebag: java.lang.NullPointerException
Expression evaluation error for Mer-kin takebag: java.lang.NullPointerException
Expression evaluation error for diving muff: java.lang.NullPointerException
Expression evaluation error for diving muff: java.lang.NullPointerException
Expression evaluation error for diving muff: java.lang.NullPointerException
Expression evaluation error for diving muff: java.lang.NullPointerException
Expression evaluation error for diving muff: java.lang.NullPointerException
Expression evaluation error for diving muff: java.lang.NullPointerException
Expression evaluation error for glowing esca: java.lang.NullPointerException
Expression evaluation error for glowing esca: java.lang.NullPointerException
Expression evaluation error for teflon swim fins: java.lang.NullPointerException
Expression evaluation error for teflon swim fins: java.lang.NullPointerException
Expression evaluation error for teflon swim fins: java.lang.NullPointerException
Expression evaluation error for teflon swim fins: java.lang.NullPointerException
Expression evaluation error for teflon swim fins: java.lang.NullPointerException
Expression evaluation error for teflon swim fins: java.lang.NullPointerException
Expression evaluation error for Goggles of Loathing: java.lang.NullPointerException
Expression evaluation error for Goggles of Loathing: java.lang.NullPointerException
Expression evaluation error for Goggles of Loathing: java.lang.NullPointerException
Expression evaluation error for Goggles of Loathing: java.lang.NullPointerException
Expression evaluation error for Goggles of Loathing: java.lang.NullPointerException
Expression evaluation error for Goggles of Loathing: java.lang.NullPointerException
Expression evaluation error for Ze™ goggles: java.lang.NullPointerException
Expression evaluation error for gnomish swimmer's ears: java.lang.NullPointerException
Expression evaluation error for gnomish swimmer's ears: java.lang.NullPointerException
Expression evaluation error for gnomish swimmer's ears: java.lang.NullPointerException
Expression evaluation error for gnomish swimmer's ears: java.lang.NullPointerException
Expression evaluation error for gnomish swimmer's ears: java.lang.NullPointerException
Expression evaluation error for gnomish swimmer's ears: java.lang.NullPointerException
Expression evaluation error for aquamariner's ring: java.lang.NullPointerException
Expression evaluation error for aquamariner's ring: java.lang.NullPointerException
Expression evaluation error for aquamariner's ring: java.lang.NullPointerException
Expression evaluation error for aquamariner's ring: java.lang.NullPointerException
Expression evaluation error for aquamariner's ring: java.lang.NullPointerException
Expression evaluation error for aquamariner's ring: java.lang.NullPointerException
Expression evaluation error for aquamariner's necklace: java.lang.NullPointerException
Expression evaluation error for aquamariner's necklace: java.lang.NullPointerException
Expression evaluation error for aquamariner's necklace: java.lang.NullPointerException
Expression evaluation error for aquamariner's necklace: java.lang.NullPointerException
Expression evaluation error for aquamariner's necklace: java.lang.NullPointerException
Expression evaluation error for aquamariner's necklace: java.lang.NullPointerException
Expression evaluation error for pearl diver's ring: java.lang.NullPointerException
Expression evaluation error for pearl diver's ring: java.lang.NullPointerException
Expression evaluation error for pearl diver's necklace: java.lang.NullPointerException
Expression evaluation error for pearl diver's necklace: java.lang.NullPointerException
Expression evaluation error for cozy scimitar: java.lang.NullPointerException
Expression evaluation error for cozy scimitar: java.lang.NullPointerException
Expression evaluation error for cozy scimitar: java.lang.NullPointerException
Expression evaluation error for cozy scimitar: java.lang.NullPointerException
Expression evaluation error for cozy scimitar: java.lang.NullPointerException
Expression evaluation error for cozy scimitar: java.lang.NullPointerException
Expression evaluation error for Staff of the Cozy Fish: java.lang.NullPointerException
Expression evaluation error for Staff of the Cozy Fish: java.lang.NullPointerException
Expression evaluation error for Staff of the Cozy Fish: java.lang.NullPointerException
Expression evaluation error for Staff of the Cozy Fish: java.lang.NullPointerException
Expression evaluation error for Staff of the Cozy Fish: java.lang.NullPointerException
Expression evaluation error for Staff of the Cozy Fish: java.lang.NullPointerException
Expression evaluation error for cozy bazooka: java.lang.NullPointerException
Expression evaluation error for cozy bazooka: java.lang.NullPointerException
Expression evaluation error for cozy bazooka: java.lang.NullPointerException
Expression evaluation error for cozy bazooka: java.lang.NullPointerException
Expression evaluation error for cozy bazooka: java.lang.NullPointerException
Expression evaluation error for cozy bazooka: java.lang.NullPointerException
Expression evaluation error for sea mantle: java.lang.NullPointerException
Expression evaluation error for sea mantle: java.lang.NullPointerException
Expression evaluation error for sea shawl: java.lang.NullPointerException
Expression evaluation error for sea shawl: java.lang.NullPointerException
Expression evaluation error for sea cape: java.lang.NullPointerException
Expression evaluation error for sea cape: java.lang.NullPointerException
Expression evaluation error for sea cape: java.lang.NullPointerException
Expression evaluation error for sea cape: java.lang.NullPointerException
Expression evaluation error for Mer-kin dragbelt: java.lang.NullPointerException
Expression evaluation error for Mer-kin dragbelt: java.lang.NullPointerException
Expression evaluation error for Mer-kin eyeglasses: java.lang.NullPointerException
Expression evaluation error for Mer-kin eyeglasses: java.lang.NullPointerException
Expression evaluation error for Mer-kin gutgirdle: java.lang.NullPointerException
Expression evaluation error for Mer-kin gutgirdle: java.lang.NullPointerException
Expression evaluation error for Mer-kin stopwatch: java.lang.NullPointerException
Expression evaluation error for Mer-kin stopwatch: java.lang.NullPointerException
Expression evaluation error for Mer-kin begsign: java.lang.NullPointerException
Expression evaluation error for Mer-kin begsign: java.lang.NullPointerException
135 combinations checked, best score 95.00
Expression evaluation error for Finstrong: java.lang.NullPointerException
Expression evaluation error for Finstrong: java.lang.NullPointerException
Expression evaluation error for Finstrong: java.lang.NullPointerException
Expression evaluation error for Finstrong: java.lang.NullPointerException
Expression evaluation error for Finstrong: java.lang.NullPointerException
Expression evaluation error for Finstrong: java.lang.NullPointerException
Expression evaluation error for Finstrong: java.lang.NullPointerException
Expression evaluation error for Finstrong: java.lang.NullPointerException
Expression evaluation error for Finstrong: java.lang.NullPointerException
Expression evaluation error for Swimming Head: java.lang.NullPointerException
Expression evaluation error for Swimming Head: java.lang.NullPointerException
Expression evaluation error for Swimming Head: java.lang.NullPointerException
Expression evaluation error for Greased-Up Familiar: java.lang.NullPointerException
Expression evaluation error for Greased-Up Familiar: java.lang.NullPointerException
Expression evaluation error for Greased-Up Familiar: java.lang.NullPointerException
Expression evaluation error for Eyes of the Dragon: java.lang.NullPointerException
Expression evaluation error for Eyes of the Dragon: java.lang.NullPointerException
Expression evaluation error for Eyes of the Dragon: java.lang.NullPointerException
Expression evaluation error for Crocodile Tear: java.lang.NullPointerException
Expression evaluation error for Crocodile Tear: java.lang.NullPointerException
Expression evaluation error for Crocodile Tear: java.lang.NullPointerException
Expression evaluation error for Familial Ties: java.lang.NullPointerException
Expression evaluation error for Familial Ties: java.lang.NullPointerException
Expression evaluation error for Familial Ties: java.lang.NullPointerException
Expression evaluation error for Emotion Sickness: java.lang.NullPointerException
Expression evaluation error for Emotion Sickness: java.lang.NullPointerException
Expression evaluation error for Emotion Sickness: java.lang.NullPointerException
Expression evaluation error for Emotion Sickness: java.lang.NullPointerException
Expression evaluation error for Emotion Sickness: java.lang.NullPointerException
Expression evaluation error for Emotion Sickness: java.lang.NullPointerException
Expression evaluation error for Swimming with Sharks: java.lang.NullPointerException
Expression evaluation error for Swimming with Sharks: java.lang.NullPointerException
Expression evaluation error for Swimming with Sharks: java.lang.NullPointerException
Expression evaluation error for Swimming with Sharks: java.lang.NullPointerException
Expression evaluation error for Swimming with Sharks: java.lang.NullPointerException
Expression evaluation error for Swimming with Sharks: java.lang.NullPointerException
Expression evaluation error for Swimming with Sharks: java.lang.NullPointerException
Expression evaluation error for Swimming with Sharks: java.lang.NullPointerException
Expression evaluation error for Swimming with Sharks: java.lang.NullPointerException
Expression evaluation error for Salty Dogs: java.lang.NullPointerException
Expression evaluation error for Salty Dogs: java.lang.NullPointerException
Expression evaluation error for Salty Dogs: java.lang.NullPointerException
Expression evaluation error for Salty Dogs: java.lang.NullPointerException
Expression evaluation error for Salty Dogs: java.lang.NullPointerException
Expression evaluation error for Salty Dogs: java.lang.NullPointerException
Expression evaluation error for Salty Dogs: java.lang.NullPointerException
Expression evaluation error for Salty Dogs: java.lang.NullPointerException
Expression evaluation error for Salty Dogs: java.lang.NullPointerException
Expression evaluation error for Brined Liver: java.lang.NullPointerException
Expression evaluation error for Brined Liver: java.lang.NullPointerException
Expression evaluation error for Brined Liver: java.lang.NullPointerException
Expression evaluation error for Brined Liver: java.lang.NullPointerException
Expression evaluation error for Brined Liver: java.lang.NullPointerException
Expression evaluation error for Brined Liver: java.lang.NullPointerException
Expression evaluation error for Brined Liver: java.lang.NullPointerException
Expression evaluation error for Brined Liver: java.lang.NullPointerException
Expression evaluation error for Brined Liver: java.lang.NullPointerException
Expression evaluation error for Donho's Bubbly Ballad: java.lang.NullPointerException
Expression evaluation error for Donho's Bubbly Ballad: java.lang.NullPointerException
Expression evaluation error for Donho's Bubbly Ballad: java.lang.NullPointerException
Expression evaluation error for Donho's Bubbly Ballad: java.lang.NullPointerException
Expression evaluation error for Donho's Bubbly Ballad: java.lang.NullPointerException
Expression evaluation error for Donho's Bubbly Ballad: java.lang.NullPointerException
Expression evaluation error for Donho's Bubbly Ballad: java.lang.NullPointerException
Expression evaluation error for Donho's Bubbly Ballad: java.lang.NullPointerException
Expression evaluation error for Donho's Bubbly Ballad: java.lang.NullPointerException
Expression evaluation error for Hairless and Airless: java.lang.NullPointerException
Expression evaluation error for Hairless and Airless: java.lang.NullPointerException
Expression evaluation error for Hairless and Airless: java.lang.NullPointerException
Expression evaluation error for Hairless and Airless: java.lang.NullPointerException
Expression evaluation error for Hairless and Airless: java.lang.NullPointerException
Expression evaluation error for Hairless and Airless: java.lang.NullPointerException
Expression evaluation error for Hairless and Airless: java.lang.NullPointerException
Expression evaluation error for Hairless and Airless: java.lang.NullPointerException
Expression evaluation error for Hairless and Airless: java.lang.NullPointerException
Expression evaluation error for Juiced Up: java.lang.NullPointerException
Expression evaluation error for Juiced Up: java.lang.NullPointerException
Expression evaluation error for Juiced Up: java.lang.NullPointerException
Expression evaluation error for Juiced Up: java.lang.NullPointerException
Expression evaluation error for Juiced Up: java.lang.NullPointerException
Expression evaluation error for Juiced Up: java.lang.NullPointerException
Expression evaluation error for Juiced Up: java.lang.NullPointerException
Expression evaluation error for Juiced Up: java.lang.NullPointerException
Expression evaluation error for Juiced Up: java.lang.NullPointerException
Expression evaluation error for Red Around the Gills: java.lang.NullPointerException
Expression evaluation error for Red Around the Gills: java.lang.NullPointerException
Expression evaluation error for Red Around the Gills: java.lang.NullPointerException
Expression evaluation error for Red Around the Gills: java.lang.NullPointerException
Expression evaluation error for Red Around the Gills: java.lang.NullPointerException
Expression evaluation error for Red Around the Gills: java.lang.NullPointerException
Expression evaluation error for Red Around the Gills: java.lang.NullPointerException
Expression evaluation error for Red Around the Gills: java.lang.NullPointerException
Expression evaluation error for Red Around the Gills: java.lang.NullPointerException
Expression evaluation error for Red Around the Gills: java.lang.NullPointerException
Expression evaluation error for Red Around the Gills: java.lang.NullPointerException
Expression evaluation error for Red Around the Gills: java.lang.NullPointerException

 

[lostcalpolydude]

The environment there isn't null, it's "none", which is completely different (since that is a String just like any other environment). I suspect that Mafia didn't update your location and related properties properly when you adventured in Spelunky Area, and a null location would result in a null environment.

 

[Veracity]

AdventureDatabase could guard against this.

	public static final String getEnvironment( String adventureName )
	{
		return AdventureDatabase.environmentLookup.get( adventureName );
	}

... by not returning null if the adventure is not in the map.

 

[Veracity]

Revision 15234 does that.