Bug - Fixed Mugs of pumpkin juice not removed from inventory when consumed

[halfvoid]

Title pretty much says it. Occurs both when consumed from the inventory manager and the relay browser.

 

[Aankhen]

Pumpkin juice is missing its plural in Mafia’s data files, so the mugs are considered separate items altogether. This should fix it:

diff -r 5deb0b4832e5 -r 21d97f97db6a src/data/itemdescs.txt
--- a/src/data/itemdescs.txt	Fri Nov 05 13:07:03 2010 +0530
+++ b/src/data/itemdescs.txt	Fri Nov 05 15:24:21 2010 +0530
@@ -4768,7 +4768,7 @@
 4762
 4763	695446947	pumpkin pie
 4764	796510425	pumpkin beer
-4765	594521132	pumpkin juice
+4765	594521132	pumpkin juice	mugs of pumpkin juice
 4766	784207428	pumpkin bomb
 4767	148094418	shin gourds	pairs of shin gourds
 4768	416163768	Staff of the November Jack-O-Lantern

 

[Theraze]

Actually, all of the pumpkin items have the same issue, which may well be why the EatDrink script is breaking for so many people currently. Instead of just changing the juice, you want the following:

4761 777322046 pumpkin pumpkins
4762
4763 695446947 pumpkin pie pumpkin pies
4764 796510425 pumpkin beer pumpkin beers
4765 594521132 pumpkin juice mugs of pumpkin juice
4766 784207428 pumpkin bomb pumpkin bombs
4767 148094418 shin gourds pairs of shin gourds
4768 416163768 Staff of the November Jack-O-Lantern Staves of the November Jack-O-Lantern
4769 919223402 pumpkin carriage pumpkin carriages pumpkin carriages

I can diff it if someone really wants me to, but since I don't tend to use IotMs, decided against actually changing my itemdescs file and making one more file that desparately checks if it's fitting in yet.

 

[Veracity]

If we don't have a plural listed, we assume that singular + "s" is the plural. So, if that is actually how an item is pluralized, nothing breaks, and there isn't really an "issue", as such.

 

[Theraze]

Ah... so still an issue for the Staff of the November Jack-O-Lantern, which becomes Staves of the November Jack-O-Lantern, or... is that detected as a staff in some way and made not to break?

 

[Veracity]

Revision 8743 adds plurals for pumpkin juice and the staff.

 

[Theraze]

Spiffy. Thanks! And thanks for interpreting through my confusion.

 

[xKiv]

The "pairs of shin gourds" is not an issue?

 

[Veracity]

Um. The item is "shin gourds". The plural is "pairs of shin gourds". The plural was already in the data file.
Your point?

 

[xKiv]

I just went from Theraze's post (#3), which simply lists all the pumpin items, and forgot to look up one post (#2), where Aankhen has a diff which already has the pair of gourds as included.

 

[Theraze]

Sorry for my addition to the confusion.

 

[Rinn]

If the player is in a state where they can access their mall store, you can automatically figure out the plural of any tradeable item by trying to add more then you have to your mall store, it even puts the plural in bold text.

Unable to add 9223372036854775807 pumpkins to your store -- you don't have 9223372036854775807 of them.

It's something that could be added to the override code if you think it's worth it.