Bug - Fixed Moxie magnet doesn't work on Left-Hand Man but maximizer recommends it.

gausie

D̰͕̝͚̤̥̙̐̇̑͗̒e͍͔͎͈͔ͥ̉̔̅́̈l̠̪̜͓̲ͧ̍̈́͛v̻̾ͤe͗̃ͥ̐̊ͬp̔͒ͪ
Staff member
I have to say I simply can't see in the code where the maximizer is even made aware of the fact that the moxie magnet even does anything at all 😬
 

lostcalpolydude

Developer
Staff member
After about 15 minutes of digging around...

In modifiers.txt, some things have "Moxie Controls MP", or "Moxie May Control MP". Find that in Modifiers.java, see that it corresponds with MOXIE_CONTROLS_MP in the list of int values just above, and then you can see where that is used later on in the code.
 

gausie

D̰͕̝͚̤̥̙̐̇̑͗̒e͍͔͎͈͔ͥ̉̔̅́̈l̠̪̜͓̲ͧ̍̈́͛v̻̾ͤe͗̃ͥ̐̊ͬp̔͒ͪ
Staff member
After about 15 minutes of digging around...

In modifiers.txt, some things have "Moxie Controls MP", or "Moxie May Control MP". Find that in Modifiers.java, see that it corresponds with MOXIE_CONTROLS_MP in the list of int values just above, and then you can see where that is used later on in the code.
Ohhhh.... we index into that array to refer to the modifier. Wild. Thanks
 

gausie

D̰͕̝͚̤̥̙̐̇̑͗̒e͍͔͎͈͔ͥ̉̔̅́̈l̠̪̜͓̲ͧ̍̈́͛v̻̾ͤe͗̃ͥ̐̊ͬp̔͒ͪ
Staff member
With that good intel I have fixed it (and some undiscovered other bugs around the same sort of thing) in r20710
 

Malibu Stacey

Active member
Thanks. I'd mark this as fixed as it showing up like the screenshot is intermittent so reproducing it isn't guaranteed.
 
Top