Bug - Fixed Monster image information incomplete

zarqon

Well-known member
As I've been making increasing use of monster images for various relay scripts, I've come across several issues.

Incorrect Values

First, some of the existing monster image names are incorrect. I've listed them here with the correct image name.

  • Tricksy pixie => trixiepixie.gif
  • Mob penguin entrepreneur => peng_ent.gif
  • Moonshriner => moonshriner.gif
  • Naughty Sorceress (3) => bigsaus.gif
  • Pygmy Janitor/Orderlies/Shaman/Witch Accountant/Witch Lawyer/Witch Nurse/Witch Surgeon => all missing final ".gif"
  • Mother Slime => ./otherimages/slimetube/stboss.gif (directory structure chosen to be consistent with Your Shadow)
  • Dreadsylvania non-bosses => Though these image names appear to be correct, for some reason the images fail to load.

Missing Values

The following monsters contain empty strings in their image field. Perhaps not all of them should have image information, but here is a complete list regardless.

  • Killer Festive Arc-Welding Elfbot
  • Killer Festive Decal-Applying Elfbot
  • Killer Festive Laser-Calibrating Elfbot
  • Killer Festive Weapons-Assembly Elfbot
  • 7-Foot Dwarf
  • Amateur Elf
  • Arc-welding Elfborg
  • Auteur Elf
  • Bow-making Mummy
  • CDMoyer's Butt
  • Chatty Coworker
  • Cookie-baking Thing from Beyond Time
  • Crys-Rock
  • Cyrus the Virus
  • Dad Sea Monkee
  • Deadwood Tree
  • Decal-applying Elfborg
  • Disorganized Files
  • Don Crimbo
  • Ed the Undying (2)
  • Ed the Undying (3)
  • Ed the Undying (4)
  • Ed the Undying (5)
  • Ed the Undying (6)
  • Ed the Undying (7)
  • Edwing Abbidriel
  • Endless Conference Call
  • Flint-Scraping Cave Elf
  • four skeleton invaders
  • fudge monkey
  • fudge oyster
  • fudge vulture
  • Fur Tree
  • Giant Pair of Tweezers
  • Gift-wrapping Vampire
  • Gnollish Bodybuilder
  • Gnollish Sorceress
  • Hammered Yam Golem
  • Hangman's Tree
  • Hideous Slide Show
  • Hotstuff's Butt
  • Hunter-Gatherer Cave Elf
  • Inebriated Tofurkey
  • Jick's Butt
  • Mob Penguin Caporegime
  • Mob Penguin Enforcer
  • Mob Penguin Goon
  • Mob Penguin Hitpenguin
  • Mob Penguin Kneecapper
  • Mob Penguin Psychopath
  • Mob Penguin Racketeer
  • Mob Penguin Smasher
  • Mob Penguin Smith
  • Mob Penguin Supervisor
  • Mr. Skullhead's Butt
  • Multi Czar's Butt
  • Mutant Circuit-Soldering Elf
  • Mutant Cookie-Baking Elf
  • Mutant Doll-Dressing Elf
  • Mutant Gift-Wrapping Elf
  • Mutant Whistle-Carving Elf
  • Plastered Can of Cranberry Sauce
  • Provocateur Elf
  • Pumpkin Tree
  • Raconteur Elf
  • Ribbon-cutting Elfborg
  • Riff's Butt
  • rock homunculus
  • rock snake
  • Rock-Banging Cave Elf
  • Rudolphus of Crimborg
  • Saboteur Elf
  • Servant Of Lord Flameface
  • Sinew-Stretching Cave Elf
  • skeletal reindeer
  • skeleton invader
  • slime1
  • slime2
  • slime3
  • slime4
  • slime5
  • Soused Stuffing Golem
  • Stocking-stuffing Zombie
  • Striking Factory-Worker Elf
  • Striking Gift-Wrapper Elf
  • Striking Middle-Management Elf
  • Striking Pencil-Pusher Elf
  • Striking Stocking-Stuffer Elf
  • Tedious Spreadsheet
  • The Abominable Fudgeman
  • The Best Game Ever
  • The Book Of Faces
  • The Colollilossus
  • The Darkness (blind)
  • The Fudge Wizard
  • The Tome Of Tropes
  • The Water Cooler
  • The Whole Kingdom
  • three skeleton invaders
  • Totally Malicious 'Zine
  • Toy-making creature from the Gray Lagoon
  • Trollipop
  • two skeleton invaders
  • Uncle Hobo
  • Underworld Tree
  • Unoptimized Database
  • Weapons-assembly Elfborg
  • Wire-Crossin' Elf
  • Your Overflowing Inbox

Blank files in mafia's image cache

This leads me to the final issue. In testing all of this, I got quite a lot of blank image files in my relay folder (and sometimes empty folders, as with Mother Slime and Your Shadow, since they include directory structure in their image name). If mafia's information is incorrect, a blank file with the incorrect name is still saved. Once I forgot to put a closing quote at the end of the img src tag and suddenly there were over a thousand blank files in my images/adventureimages directory, with names like "question.gif%20height=40%20width=40" and so forth. It seems like some kind of failsafe to ensure that only actual, existing files are cached would be handy.

I've attached the tiny little relay script I used to test this information. If you run the script, you'll notice a good number of monster images don't display (most of them Dread monsters), and then if you check your images folder, you'll also find various blank files due to the incorrect info (and due to not making special cases for directory information in the image name).
 

Attachments

The following image names are all probably correct.
  • Killer Festive Arc-Welding Elfbot
    borgelf1.gif
  • Killer Festive Decal-Applying Elfbot
    borgelf4.gif
  • Killer Festive Laser-Calibrating Elfbot
    borgelf2.gif
  • Killer Festive Weapons-Assembly Elfbot
    borgelf3.gif
  • Amateur Elf
    elf_amateur.gif
  • Arc-welding Elfborg
    borgelf1.gif
  • Auteur Elf
    elf_auteur.gif
  • Bow-making Mummy
    crimonster3.gif
  • CDMoyer's Butt
    butt.gif
  • Chatty Coworker
    c10chatty.gif
  • Cookie-baking Thing from Beyond Time
    crimonster2.gif
  • Crys-Rock
    crys_rock.gif
  • Cyrus the Virus
    prim_cyru.gif
  • Dad Sea Monkee
    dad_machine.gif
  • Deadwood Tree
    shiv_dead.gif
  • Decal-applying Elfborg
    borgelf4.gif
  • Disorganized Files
    c10files.gif
  • Don Crimbo
    doncrimbo.gif
  • Ed the Undying (2)
    ed2.gif
  • Ed the Undying (3)
    ed3.gif
  • Ed the Undying (4)
    ed4.gif
  • Ed the Undying (5)
    ed5.gif
  • Ed the Undying (6)
    ed6.gif
  • Ed the Undying (7)
    ed7.gif
  • Edwing Abbidriel
    edwing.gif
  • Endless Conference Call
    c10confcall.gif
  • Flint-Scraping Cave Elf
    caveelf3.gif
  • four skeleton invaders
    bigskeleton4.gif
  • fudge monkey
    fudgemonkey2.gif
  • fudge oyster
    fudgeoyster.gif
  • fudge vulture
    fudgevulture.gif
  • Fur Tree
    shiv_fur.gif
  • Giant Pair of Tweezers
    tweezers.gif
  • Gift-wrapping Vampire
    crimonster5.gif
  • Gnollish Bodybuilder
    dk_builder.gif
  • Gnollish Sorceress
    gnollmage.gif
  • Hammered Yam Golem
    drunkyam.gif
  • Hangman's Tree
    shiv_hangman.gif
  • Hideous Slide Show
    c10slideshow.gif
  • Hotstuff's Butt
    butt.gif
  • Hunter-Gatherer Cave Elf
    caveelf2.gif
  • Inebriated Tofurkey
    drunktofurkey.gif
  • Jick's Butt
    butt.gif
  • Mob Penguin Caporegime
    pengcapo.gif
  • Mob Penguin Enforcer
    pengthug.gif
  • Mob Penguin Goon
    pengbook.gif
  • Mob Penguin Hitpenguin
    penggun.gif
  • Mob Penguin Kneecapper
    pengthug.gif
  • Mob Penguin Psychopath
    pengpsycho.gif
  • Mob Penguin Racketeer
    pengracket.gif
  • Mob Penguin Smasher
    pengsmasher.gif
  • Mob Penguin Smith
    hazmatpeng.gif
  • Mob Penguin Supervisor
    pengphone.gif
  • Mr. Skullhead's Butt
    butt.gif
  • Multi Czar's Butt
    butt.gif
  • Mutant Circuit-Soldering Elf
    antlerelf.gif
  • Mutant Cookie-Baking Elf
    elfblob.gif
  • Mutant Doll-Dressing Elf
    elflimbs.gif
  • Mutant Gift-Wrapping Elf
    elfclaw.gif
  • Mutant Whistle-Carving Elf
    elfhulk.gif
  • Plastered Can of Cranberry Sauce
    drunkcrancan.gif
  • Provocateur Elf
    elf_provocateur.gif
  • Pumpkin Tree
    shiv_pumpkin.gif
  • Raconteur Elf
    elf_raconteur.gif
  • Ribbon-cutting Elfborg
    borgelf2.gif
  • Riff's Butt
    butt.gif
  • rock homunculus
    rock_guy.gif
  • rock snake
    rock_snake.gif
  • Rock-Banging Cave Elf
    caveelf1.gif
  • Rudolphus of Crimborg
    rudolfus.gif
  • Saboteur Elf
    elf_saboteur.gif
  • Sinew-Stretching Cave Elf
    caveelf4.gif
  • skeletal reindeer
    crimonster6.gif
  • skeleton invader
    bigskeleton.gif
  • Soused Stuffing Golem
    drunkstuffing.gif
  • Stocking-stuffing Zombie
    crimboelf.gif
  • Striking Factory-Worker Elf
    crimboelf.gif
  • Striking Gift-Wrapper Elf
    crimboelf.gif
  • Striking Middle-Management Elf
    crimboelf.gif
  • Striking Pencil-Pusher Elf
    crimboelf.gif
  • Striking Stocking-Stuffer Elf
    crimboelf.gif
  • Tedious Spreadsheet
    c10spreadsheet.gif
  • The Abominable Fudgeman
    fudgeman.gif
  • The Best Game Ever
    c10bge.gif
  • The Book Of Faces
    c10faces.gif
  • The Colollilossus
    colollilossus.gif
  • The Darkness (blind)
    darkness.gif
  • The Fudge Wizard
    fudgewizard.gif
  • The Tome Of Tropes
    c10tropes.gif
  • The Water Cooler
    c10cooler.gif
  • The Whole Kingdom
    wholekingdom.gif
  • three skeleton invaders
    bigskeleton3.gif
  • Totally Malicious 'Zine
    c10tmz.gif
  • Toy-making creature from the Gray Lagoon
    crimonster1.gif
  • Trollipop
    trollipop.gif
  • two skeleton invaders
    bigskeleton2.gif
  • Uncle Hobo
    unclehobo.gif
  • Underworld Tree
    shiv_underworld.gif
  • Unoptimized Database
    c10database.gif
  • Weapons-assembly Elfborg
    borgelf3.gif
  • Wire-Crossin' Elf
    elf_wires.gif
  • Your Overflowing Inbox
    c10inbox.gif


Tricky. Worry about these later?
  • 7-Foot Dwarf
  • Servant Of Lord Flameface
  • slime1
  • slime2
  • slime3
  • slime4
  • slime5
 
Thanks Bale, that saves me some time. Have got a local patch that fixes the incorrect ones.

Currently wishing I hadn't cleared my mafia cache a couple of years back.
 
Any other dev opinions on the ordering of monsters.txt ? Every time I do an exercise like this I wish that either a) all the old event monsters had their own section, or b) all the monsters were alphabetical.

I don't really mind which, and I'm happy to change it. If the latter, I'd still suggest adding them at the bottom in a group til all spaded and sorted, and only then adding them into the main alphabetical list.
 
zarqon said:
  • 7-Foot Dwarf
  • Servant Of Lord Flameface
  • slime1
  • slime2
  • slime3
  • slime4
  • slime5

I'm not sure what to do about those.

7-Foot Dwarf isn't too hard. I'm pretty sure that it once referred to two indistinguishable monsters: 7-Foot Dwarf (Royale) and 7-Foot Dwarf (Moiling) which both used the image: miner.gif

As for Servant Of Lord Flameface, it is harder since there is no actual monster by that name. However, the Fire Servant (which it probably refers to) uses a whole bunch of images. Similarly slime1 though slime5 each have a bunch of images and only have those names to help KoLmafia distinguish them. I'd suggest that for these six monsters we could chose one of the many images to represent it? Either pick the most photogenic or the one with the lowest integer on the end.
 
I came to pretty much the same conclusions. Though I worked on the theory that the 7-Foot Dwarf would be identical to the 7-Foot Dwarf Replicant, as replicants are indistinguishable from the original.

There are loads of places we pick an example one, so this is consistent. I'm tempted to pick some random video game ones rather than using the ? from the Manuel too, but haven't done so.
 
Last edited:
There are loads of places we pick an example one, so this is consistent. I'm tempted to pick some random video game ones rather than using the ? from the Manuel too, but haven't done so.

I would be totally behind that decision! That eroteme is so ugly and uninteresting.

Video Game Boss - http://images.kingdomofloathing.com/adventureimages/faq_boss3.gif faq_boss3.gif
Video Game Miniboss - http://images.kingdomofloathing.com/adventureimages/faq_miniboss2.gif faq_miniboss2.gif
Video Game Minion (weak) - http://images.kingdomofloathing.com/adventureimages/faq_mushroom1.gif faq_mushroom1.gif
Video Game Minion (moderate) - http://images.kingdomofloathing.com/adventureimages/faq_ghost2.gif faq_ghost2.gif
Video Game Minion (strong) - http://images.kingdomofloathing.com/adventureimages/faq_blob3.gif faq_blob3.gif
 
Thanks Bale and Darzil! That test script now shows all monsters with no unknowns!

I've sometimes wondered why the Servant of Lord Flameface (which is in fact the Fire Servant, as I know from back when I was faxputtying them for hot daubs) was named as such.

BatMan RE's Adventure Again box thanks you profusely.
Even more excitingly, BatMan RE's friggin' awesome (and as yet unreleased) integrated/standalone factoid tracker thanks you profusely.

Both of these substitute the Possibility Giant image in the case that there is no image information, and now I note a pleasant absence of question marks.
 
I came to pretty much the same conclusions. Though I worked on the theory that the 7-Foot Dwarf would be identical to the 7-Foot Dwarf Replicant, as replicants are indistinguishable from the original.

There are loads of places we pick an example one, so this is consistent. I'm tempted to pick some random video game ones rather than using the ? from the Manuel too, but haven't done so.

If monster id is added, then that's another possible ordering. It would generally put older monsters higher up in the list. Not all monster ids are available, so some monsters would still need to be sorted separately.
 
Both of these substitute the Possibility Giant image in the case that there is no image information, and now I note a pleasant absence of question marks.

You mean, an absence of question marks, except for the actual Possibility Giant, right? That's not a complete absence although I suppose it is still a pleasant absence.



If monster id is added, then that's another possible ordering. It would generally put older monsters higher up in the list. Not all monster ids are available, so some monsters would still need to be sorted separately.

Thanks for finding another reason to implement it! :D
 
The particular absence I noted was both pleasant and complete, as I have all of the Possibility Giant's factoids. :P
 
Back
Top