Bug - Not A Bug Monster ID and Fax

[fronobulax]

Using the GUI I ask easyfax for a Knob Goblin Embezzler. It lists the monster as "Knob Goblin Embezzler<!-- monsterid: 530 --> [Knob Goblin Embezzler&lt;!-- monsterid: 530 --&gt;]" in the GUI, asks, and then times out. I expected a faxed monster.

The chat window shows

[08:23] fronobulax: Knob Goblin Embezzler&lt;!-- monsterid: 530 --&gt;

After it times out I type "Knob Goblin Embezzler" and one is received almost immediately.

[08:23] fronobulax: Knob Goblin Embezzler&lt;!-- monsterid: 530 --&gt;
[08:24] fronobulax: Knob Goblin Embezzler
[08:24] Easyfax: Your fax is ready.

It is quite likely the problem was introduced with r27923. It could be argued that easyfax needs to accommodate the change or that KoLmafia needs to change and send easyfax what was expected.

 

[Ryo_Sangnoir]

KoLMafia is sending Easyfax what it says it wants according to its XML:

https://svn.code.sf.net/p/easyfax/code/Easyfax.xml

So it's a problem on that end.

 

[fronobulax]

KoLMafia is sending Easyfax what it says it wants according to its XML:

https://svn.code.sf.net/p/easyfax/code/Easyfax.xml

So it's a problem on that end.

Yep. As near as I can reconstruct the monster ID was not in easyfax.xml until after the KoLmafia change. The commit messages refer to an automated update so it would appear that the process making the update was not expecting the change.

 

[Ryo_Sangnoir]

I expect it was reading the monster name from the photocopy, and thus it's the KoL change, not the Mafia change. But yes, I expect it's automated.

 

[fronobulax]

OK. Whatever the source it is Not a Bug. Thanks.

 

[Crowther]

Yes, Not a Bug. It is automated and yes it should have automatically handed this KoL change. However, easyfax has one and only one special character. The colon ( : ) is not allowed in monster names. This is why messages are being dropped with no response. I'll switch characters.

 

[Crowther]

Okay, switching characters got things working right again. As more faxes are looked at the problem with ambiguous monster names should be fixed.

 

[fronobulax]

Okay, switching characters got things working right again. As more faxes are looked at the problem with ambiguous monster names should be fixed.

I'm not seeing any fixes. Maybe it is because I only look at the first few monsters displayed as options?

 

[Crowther]

I never use the fax GUI, but I just brought it up and I see monster ids for most (not all monsters).
This is the file mafia uses to populate that list and it also has monster ids.

 

[fronobulax]

I never use the fax GUI, but I just brought it up and I see monster ids for most (not all monsters).
This is the file mafia uses to populate that list and it also has monster ids.

See the first post.

Compare the GUI renditions for EasyFax and OnlyFax if desired.

Using

<name>1335 HaXx0r&amp;lt;!-- monsterid: 141 --&amp;gt;</name>
<actual_name>1335 HaXx0r&amp;lt;!-- monsterid: 141 --&amp;gt;</actual_name>
<command>1335 HaXx0r&amp;lt;!-- monsterid: 141 --&amp;gt;</command>
<category>None</category>

as an example, mafia appears to display <actual name> in the GUI. When <actual name> is requested mafia sends <command> and the request fails.

When I eliminated the GUI and typed <command> I got nothing but when I stripped out the monster id and typed the command I got a fax.

So my observations are two - there are cases when sending <command> do not return a fax AND it is difficult to compare monsters across faxbots and Monster Manual when the monster ID in present.

This is not a big deal in that I don't think EasyFax has any monster than Only Fax doesn't.

There could be some impatience on my part since I'm pretty sure a month ago all monsters had IDs and now some of them don't, i.e. actual orcish frat boy, so things are perhaps gradually changing.

 

[fronobulax]

In the GUI I noticed some duplication today. Adventurer echo was one, but not the only. There were entries both with and without the monster id. I confirmed that there were two entries in the JSON.