Bug - Fixed Maximizer suggests making equally powerful gear (famwt only?)

[Erosion]

If you try to maximize famwt and have ghostly reins (+10), maximizer will still suggest you create a burning crane (+10) if the "creatable" setting is on. Same for whittled bear (+5) when you have other +5 accessories available.
Obviously you can change the setting, but no other equipment stat seems to have this issue.

EDIT: nc and +c have this issue too, see xiblaxian/brogre vs firework hat

 

[ckb]

have you tried "familiar weight, -tie" ?
maximizer will prefer certain modifiers by default.

 

[Erosion]

have you tried "familiar weight, -tie" ?
maximizer will prefer certain modifiers by default.

The suggestion to buy/create items is removed properly with "familiar weight, -tie" even in create mode, but I find it strange that other stats don't do this because presumably other enchants don't matter when you're only looking to maximize one thing.

It seems like for some stats, it will always recommend you spend resources to make a thing even if you have an equally powerful item, which feels bad. Mushroom shield vs whittled walking stick (costs resources), even when you currently have a mushroom shield (and not in any other form) is another example.

 

[MCroft]

The suggestion to buy/create items is removed properly with "familiar weight, -tie" even in create mode, but I find it strange that other stats don't do this because presumably other enchants don't matter when you're only looking to maximize one thing.

It seems like for some stats, it will always recommend you spend resources to make a thing even if you have an equally powerful item, which feels bad. Mushroom shield vs whittled walking stick (costs resources), even when you currently have a mushroom shield (and not in any other form) is another example.

There's a small set of "tiebreaker" stats which are given a small nudge in case of ties.

So if Maximizer gets the same score for a moss-covered, three-handled family gradunza as a yak anorak, then each of them is run against this string unless you have "-tie" in the maximize string.

    private static final String TIEBREAKER = "1 familiar weight, 1 familiar experience, 1 initiative, 5 exp, 1 item, 1 meat, 0.1 DA 1000 max, 1 DR, 0.5 all res, -10 mana cost, 1.0 mus, 0.5 mys, 1.0 mox, 1.5 mainstat, 1 HP, 1 MP, 1 weapon damage, 1 ranged damage, 1 spell damage, 1 cold damage, 1 hot damage, 1 sleaze damage, 1 spooky damage, 1 stench damage, 1 cold spell damage, 1 hot spell damage, 1 sleaze spell damage, 1 spooky spell damage, 1 stench spell damage, -1 fumble, 1 HP regen max, 3 MP regen max, 1 critical hit percent, 0.1 food drop, 0.1 booze drop, 0.1 hat drop, 0.1 weapon drop, 0.1 offhand drop, 0.1 shirt drop, 0.1 pants drop, 0.1 accessory drop, 1 DB combat damage, 0.1 sixgun damage";

Since that has no preference for cost/resources used (except mana), will choose the one with highest score.

It's helpful, but it's naive and not flexible and hasn't been updated in a while. And sometimes it causes odd things.

 

[heeheehee]

Hi! I suspect r20934 fixes this issue, but please reply and/or reopen if it doesn't.