Bug - Fixed Maximizer no longer suggesting Bird-a-Day skills, even if relevant to the search string

[Glitch]

Hi!

In the past, the maximizer was great at suggesting when my "Seek out %birdname%" and "Visit your Favorite Bird" skills were relevant to what I was searching for. But for the past month (maybe more?) it won't list those two skills at all.

Attached are screenshots of what happens when I search for -combat. I've included the effects those two skills generate when cast manually immediately after the failed maximizer search.

I searched through the forum to see if the bug has already been reported, but couldn't find anything. I'm running KoLmafia r27238.

My apologies in advance if this is user error, but I haven't been able to figure out what changed. It definitely worked in the past, and it was AMAZING when it did. Thanks!

 

[Ryo_Sangnoir]

I agree. Last known good is r26967, first bad is r26968. Which means the bug was introduced in this benign PR from phulin:

Go back to lazy parsing of modifier strings. by phulin · Pull Request #1307 · kolmafia/kolmafia

Switching to eager parsing of modifier strings had the unfortunate effect of making resetModifiers and thus KoLCharacter.reset much slower, causing the test suite to time out. This PR returns to la...

github.com

Well, the problem certainly isn't obvious!

`modtrace` still works for the blessing too -- puzzling.

 

[Ryo_Sangnoir]

Fixed in r27247.

 

[Glitch]

Fixed in r27247.

Thank you so much @Ryo_Sangnoir!