Bug Maximizer is valuing experience/ML as though it were Muscle Experience Percent

[Shiverwarp]

I believe this is a recent introduction, and seems to also be other forms of exp increasers being valued as "Muscle Experience Percent"

on mafia r27103

I noticed because my script that were maximizing for glitch reward are suddenly equipping monster level equipment, and I die because it becomes stun immune


reproduction:

The maximizer string of

+10 Muscle Experience Percent, 0.005HP, -tie

will result in this equipment from the maximizer:


I expect the government issued slacks and maybe the garbage shirt, but everything else shouldn't be getting valued like that


On r27100 I get the expected output:



So sometime inbetween these commits the issue was introduced

EDIT: Just tested, this issue appears to have been introduced in r27101

 

[Ryo_Sangnoir]

Thanks for the detailed report, I'll check after work.

"exp" does include ML, but "Muscle Experience Percent" should be exact-matching to a different modifier.

 

[Ryo_Sangnoir]

Okay, so the problem is in https://github.com/kolmafia/kolmafi...8be3c66d759159b4d47eb1ee171b59e2ed7c6184L5347: when I converted the modifier indexing, I assigned the "class" modifier to the same one involved in the calculation (stat exp pct) while it should have been assigned to stat exp.